Add title, frontend_title to membership type

[mattwire]

Overview

https://lab.civicrm.org/dev/core/-/issues/4627

See #28182 and #34153

Re-work of original PR from @eileenmcnaughton

Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

Comments

Anything else you would like the reviewer to note

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[colemanw]

@mattwire this is a good start. The sql upgrader need a bit more finesse to handle the case where the columns have already been added (e.g. when the upgrader runs multiple times subsequent runs should be no-op). To handle that cleanly, the whole thing probably needs to be in one function.

[colemanw]

@mattwire I was able to fix almost every test, however:

• The multilingual upgrader fails and I think this may be because we've stopped using versioned schemaStructure files in our upgrader scripts and maybe that was premature because we don't seem to have any working alternative to that.
• I had a hard time grokking CRM_Core_Payment_AuthorizeNetIPNTest to understand what was causing the failure

Once those are fixed, this PR still isn't functional, because the new fields aren't displayed. I did add these new fields to the admin form when creating & viewing membership types, but they also need to be added to front-end forms.