Support for nested repeating subfields #446
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a dataset has two `repeating_subfields` fields such that the earlier has at least two entries, removing an entry that isn't the last breaks the later field. In this instance, `contact_address` is simply absent from the dataset. In others, it could reorder the subfields. This is because in `expand_form_composite`, the indexes dictionary isn't scoped to the field, so here `indexes['1'] = 0` due to the deletion, then `indexes['0'] = 1` for `contact_address`, but 1 is out of range for the `contact_address` list.
- JS Module: include field name in many names to avoid touching inner fields - Template: the other half of the above - `_expand`: recurse correctly on subfields - `expand_form_composite`: rewrite to handle nested subfields. This also fixes the issue mentioned in the previous commit, that indexes are not scoped to the field. Also adds a test (`test_dashed_field_name_create`) testing fields similar to those in `ckanext-fluent`, as those broke in development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much like #429, this adds support for nesting
repeating_subfields.This only exists because #429 doesn't apply cleanly anymore.
I'm aware of two limitations, both apparently imposed by CKAN's handling of nested schemas:
A field with repeating subfields being the only subfield of a field crashes, due to this check.
This seems like it should be a relatively rare case.
Validators aren't applied to an empty leaf dictionary.
I've worked around that in the validators test case, by adding a field there.
This generally shouldn't be a problem when updating with a form, but I'm not sure how it would work with an API update.
This also fixes an issue, tested in the first commit, where deleting an instance of a
repeating_subfieldsfield would either reorder or remove entries of lexically laterrepeating_subfieldsfields.Closes #429