Skip to content

fix redirect when name not passed in form #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix redirect when name not passed in form #448

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4f040a
fix redirect when name not passed in form
wardi Aug 19, 2025
eeeb51a
more cautious redirect
wardi Aug 19, 2025
d433e42
fall back to old redirect
wardi Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions ckanext/scheming/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,21 @@ def post(self, package_type):
rval = super(SchemingCreateView, self).post(package_type)
if getattr(rval, 'status_code', None) == 302:
# successful create, send to page 2 instead of resource new page
return h.redirect_to(
'{}.scheming_new_page'.format(package_type),
id=request.form['name'],
page=2,
)
# extract id/name from redirect
loc = rval.location.rsplit('/', 3)
if loc[2:] == ['resource', 'new']:
return h.redirect_to(
'{}.scheming_new_page'.format(package_type),
id=loc[1],
page=2,
)
# fall back to passed name field if can't parse redirect
if 'name' in request.form:
return h.redirect_to(
'{}.scheming_new_page'.format(package_type),
id=request.form['name'],
page=2,
)
return rval


Expand Down