Avoid loading R/W datastore resources #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for compatibility with CKAN Table Designer feature
ThrawnCA
approved these changes
Jan 27, 2025
duttonw
requested changes
Jan 28, 2025
ckanext/xloader/jobs.py
Outdated
| # check if the resource url_type is a datastore | ||
| if resource.get('url_type') == 'datastore': | ||
| logger.info('Ignoring resource - url_type=datastore - dump files are ' | ||
| if resource.get('url_type') in h.datastore_rw_resource_url_types(): |
There was a problem hiding this comment.
Needs backwards support for for 2.10.x since datastore_rw_resource_url_types only exists in 2.11.
https://github.com/ckan/ckan/blob/ckan-2.11.1/ckanext/datastore/helpers.py#L242 (exists since May 2023)
https://github.com/ckan/ckan/blob/ckan-2.10.6/ckanext/datastore/helpers.py (does not include 'datastore_rw_resource_url_types' )
i.e.
if hasattr(h, "datastore_rw_resource_url_types"):
datastore_rw_resource_url_types = h.datastore_rw_resource_url_types()
else:
#fallback for 2.10.x or older.
datastore_rw_resource_url_types = ['datastore']
if resource.get('url_type') in datastore_rw_resource_url_types :
wardi
commented
Jan 28, 2025
duttonw
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for compatibility with CKAN Table Designer feature