feat: add selective HTTP error retries for network failures #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add HTTPError to retryable errors for specific status codes (408, 429, 500, 503, 504, 507) and increase max retries to 3. Improves reliability for temporary network issues. Fixes ckan#254
duttonw
requested changes
Aug 11, 2025
There was a problem hiding this comment.
Got a failing test, could you also add a test for non retryable error (or link to where that is tested).
It would be good to a test which has all the 'error codes' you have in the list to show they all pass, and then a few extras which are should not retry. (ie. 404).
https://docs.pytest.org/en/stable/example/parametrize.html
=========================== short test summary info ============================
FAILED ckanext/xloader/tests/test_jobs.py::TestXLoaderJobs::test_retry_on_timeout_error - AssertionError: assert 'Express Load completed' in '2025-08-11 11:54:34,004 INFO [ckan.cli] Using configuration file /__w/ckanext-xloader/ckanext-xloader/test.ini\n2025...025-08-11 11:54:34,623 INFO [ckan.lib.jobs] Worker rq:worker:5a22d81466b34993bf8c7bf2415bf0b4 (PID 173) has stopped\n'
============= 1 failed, 103 passed, 5 skipped in 88.65s (0:01:28) ==============
ThrawnCA
reviewed
Aug 11, 2025
| return 'error' if errored else None | ||
|
|
||
|
|
||
| def handle_retryable_error(e, input, job_id, job_dict, logger, error_state): |
There was a problem hiding this comment.
This function name should perhaps start with an underscore since it's internal.
Test all retryable errors (DB, HTTP timeouts) and non-retryable errors (4xx HTTP codes) with single parametrized test method.
duttonw
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add HTTPError to retryable errors for specific status codes (408, 429, 500, 503, 504, 507) and declare max retries in config variable. Improves reliability for temporary network issues.
Fixes #254