Conversation
Test inf-sup with morphological snakes
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #304 +/- ##
==========================================
- Coverage 93.03% 92.99% -0.04%
==========================================
Files 742 778 +36
Lines 13564 14440 +876
==========================================
+ Hits 12619 13429 +810
- Misses 945 1011 +66 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| temp_5 = create_like(output_image) | ||
|
|
||
| for _ in range(num_iter): | ||
| set(temp_3, 0) |
There was a problem hiding this comment.
Hint: I had to initialize this image here with 0 because the create* functions only allocate memory. Further down, we compute temp_3 += .... which might be dangerous with a non-initialized image.
|
Thanks for finishing this @haesleinhuepf! It works as expected for me. |
Hi @grahamross123 and @StRigaud ,
just to let you know: I made the
morphological_chan_vesework. I'm adding a comment below highlighting the little tricky bit. I also renamed the function to be more similar to the scikit-image API.If you have time, give it a try. I will otherwise merge and release in about a week.
Big thanks again for working on this!
closes #301
closes #229
closes #296
CC @jo-mueller