Skip to content

Commit 975ff12

Browse files
fix: accept 'required' fields [#285] (#290)
* feat: improve test framework [#281] (#287) * feat: improve test framework [#281] * fix: make name change test more sensible [#281] * fix: obfuscate identifiers better and more often [#281] # Conflicts: # packages/clerk_auth/test/integration/clerk_api/environment_test.dart # packages/clerk_auth/test/integration/clerk_api/sign_in_test.dart # packages/clerk_auth/test/integration/clerk_api/sign_up_test.dart # packages/clerk_auth/test/integration/clerk_api/user_details_test.dart # packages/clerk_auth/test/integration/clerk_auth/sign_in_test.dart # packages/clerk_auth/test/integration/clerk_auth/sign_up_test.dart # packages/clerk_auth/test/test_helpers.dart * Fix required fields currently not updating when call updateUser (#285) * Fix required field does not update when call updateUser Required fields currently not updating when call updateUser in clerk_auth * Create json_serialization_helpers_test.dart * fix: change variable name [#285] * fix: rebase [#285] * fix: reformat [#285] --------- Co-authored-by: Krisada Adoolrattananuwat (Tak) <80890688+krisadamqdc@users.noreply.github.com>
1 parent 9c1c031 commit 975ff12

File tree

75 files changed

+99
-75
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

75 files changed

+99
-75
lines changed

packages/clerk_auth/lib/src/utils/json_serialization_helpers.dart

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@ DateTime intToDateTime(dynamic input) {
1111
/// Convert a [DateTime] to an [int]. For JsonSerializable
1212
int dateTimeToInt(DateTime dt) => dt.millisecondsSinceEpoch;
1313

14-
/// [true] if a value is ['on'], else [false]. For JsonSerializable
15-
bool isOn(dynamic on) => on == 'on';
14+
/// [true] if a value is ['on'] or ['required'], else [false]. For
15+
/// JsonSerializable
16+
bool isOn(dynamic value) => value == 'on' || value == 'required';
1617

1718
/// [true] if a value is [true], else [false]. For JsonSerializable
1819
bool isTrue(dynamic boolean) => boolean == true;

packages/clerk_auth/test/_responses/clerk_api/sign_in_test/email_and_password/001.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/clerk_auth/test/_responses/clerk_api/sign_in_test/email_and_password/002.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/clerk_auth/test/_responses/clerk_api/sign_in_test/email_code/001.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)