Merge pull request NCAR#1104 from climbfuji/bugfix/ugwp_driver_v0_uninit_main

grantfirl · web-flow · commit 0f1b7269f307 · 2025-03-10T16:25:22.000-04:00
Bug fix in physics/GWD/ugwp_driver_v0.F to prevent using uninitialized Bnv2 array in line 350
diff --git a/physics/GWD/ugwp_driver_v0.F b/physics/GWD/ugwp_driver_v0.F
@@ -349,7 +349,9 @@ SUBROUTINE GWDPS_V0(IM,  km,    imx, do_tofd,
           BVF2 = grav2 * RDZ * (VTK(I,K+1)-VTK(I,K))
      &                       / (VTK(I,K+1)+VTK(I,K))
           bnv2(i,k+1) = max( BVF2, bnv2min )
-          RI_N(I,K+1) = Bnv2(i,k)/SHR2        ! Richardson number consistent with BNV2
+          ! https://github.com/NCAR/ccpp-physics/issues/1103
+          !RI_N(I,K+1) = Bnv2(i,k)/SHR2        ! Richardson number consistent with BNV2
+          RI_N(I,K+1) = Bnv2(i,max(k,2))/SHR2        ! Richardson number consistent with BNV2
 !
 ! add here computation for Ktur and OGW-dissipation fro VE-GFS
 !

Original file line number	Diff line number	Diff line change
`@@ -349,7 +349,9 @@ SUBROUTINE GWDPS_V0(IM, km, imx, do_tofd,`
`349`	`349`	`BVF2 = grav2 * RDZ * (VTK(I,K+1)-VTK(I,K))`
`350`	`350`	`& / (VTK(I,K+1)+VTK(I,K))`
`351`	`351`	`bnv2(i,k+1) = max( BVF2, bnv2min )`
`352`		`- RI_N(I,K+1) = Bnv2(i,k)/SHR2 ! Richardson number consistent with BNV2`
	`352`	`+ ! https://github.com/NCAR/ccpp-physics/issues/1103`
	`353`	`+ !RI_N(I,K+1) = Bnv2(i,k)/SHR2 ! Richardson number consistent with BNV2`
	`354`	`+ RI_N(I,K+1) = Bnv2(i,max(k,2))/SHR2 ! Richardson number consistent with BNV2`
`353`	`355`	`!`
`354`	`356`	`! add here computation for Ktur and OGW-dissipation fro VE-GFS`
`355`	`357`	`!`