Enable adding columns in auto migrations in schema crate
#2956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubham8287
force-pushed
the
jgilles/add_columns
branch
from
5268953 to
1814483
Compare
Shubham8287
reviewed
Jul 23, 2025
| @@ -129,11 +129,11 @@ error[E0277]: `&'a Alpha` cannot appear as an argument to an index filtering ope | |||
| &ConnectionId | |||
| &Identity | |||
| &Lifecycle | |||
| &RawMiscModuleExportV9 | |||
There was a problem hiding this comment.
@Centril UI tests were failing until I updated this file. I believe it's because the trait FilterableValues was auto-implemented for RawMiscModuleExportV9, but this PR changes the enum to include a variant with data, which affects the generated messages.
Shubham8287
force-pushed
the
jgilles/add_columns
branch
from
1814483 to
364e617
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This adds auto migration support to the
schemacrate.Additional changes are needed to fully implement this feature: see #2912
API and ABI breaking changes
None
Expected complexity level and risk
1, at this level the change is fairly straightforward. The integration will be more difficult.
Testing
Added
schemaunit tests for success/failure cases.