Skip to content

Update quickstart-chat client module bindings from server #2976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2025

Conversation

alex47
Copy link
Contributor

@alex47 alex47 commented Jul 22, 2025

Description of Changes

The example quickstart-chat client can not communicate with the example server, because the reducer names have been updated in the server, but not in the module bindings of the client.
I have run the following command in \sdks\csharp\examples~\quickstart-chat\:
spacetime generate --lang csharp --out-dir .\client\module_bindings\ --project-path server

API and ABI breaking changes

No changes.

Expected complexity level and risk

1

Testing

  • With the example server and client send and receive messages

@alex47 alex47 marked this pull request as ready for review July 22, 2025 20:31
@CLAassistant
Copy link

CLAassistant commented Jul 24, 2025

CLA assistant check
All committers have signed the CLA.

@bfops
Copy link
Collaborator

bfops commented Jul 24, 2025

@alex47 Can you merge in master? We fixed a bug with some of those tests.

Copy link
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM once master is merged in and those tests pass! Thank you!

@bfops bfops added this pull request to the merge queue Jul 24, 2025
Merged via the queue into clockworklabs:master with commit ce90583 Jul 25, 2025
17 of 18 checks passed
Shubham8287 pushed a commit that referenced this pull request Jul 28, 2025
Co-authored-by: rekhoff <r.ekhoff@clockworklabs.io>
Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
bfops added a commit that referenced this pull request Aug 7, 2025
Co-authored-by: rekhoff <r.ekhoff@clockworklabs.io>
Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants