Skip to content

Generate Websocket token from auth in Unity WebGL build #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2025

Conversation

FME849
Copy link
Contributor

@FME849 FME849 commented Jul 25, 2025

Description of Changes

This is a fix for community bug which auth token is not used to create Websocket connection in Unity WebGL build.
The issue here: clockworklabs/com.clockworklabs.spacetimedbsdk#352

API and ABI breaking changes

None

Expected complexity level and risk

1

Testing

  • Using OAuth2.0 tokens, you should get the same Identity even when the token is refreshed in the WebGL build

@CLAassistant
Copy link

CLAassistant commented Jul 25, 2025

CLA assistant check
All committers have signed the CLA.

@FME849
Copy link
Contributor Author

FME849 commented Jul 25, 2025

Hi @jdetter, I opened the PR to fix the auth token in WebGL build

Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question on this, I'm testing this now

@jdetter
Copy link
Collaborator

jdetter commented Jul 25, 2025

Hi @jdetter, I opened the PR to fix the auth token in WebGL build

Thank you for transferring the PR! 👍

@jdetter jdetter mentioned this pull request Jul 28, 2025
4 tasks
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, functionality tested via Blackholio and it works just fine. I'm able to resume the same play session using the same token when building for WebGL. Thanks for the PR @FME849! 🙏

@jdetter jdetter added this pull request to the merge queue Jul 28, 2025
Merged via the queue into clockworklabs:master with commit 5f75c9d Jul 28, 2025
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants