This repository was archived by the owner on Jun 25, 2020. It is now read-only.
GoDoc fixes to re-enable the linter golint #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some exported types were unexported for better encapsulation.
* GoDoc additions * Removed the info endpoint, as it did nothing. I do not believe any health checks used this endpoint either.
josephlewis42
approved these changes
Jan 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to re-enable the
golintlinter as part of the CI process.The reason it has been disabled is missing GoDoc.
This PR fixes GoDoc for:
The
src/stackdriver-nozzle/mockspackaged is excluded from linting for now. An Issue has been opened to explore better solutions: #245In some cases, variables which didn't need to be exported are no longer exported.
I also removed the example app's
/infoendpoint. I do not think it was being used by any health checks.