Feat: add ready column to cf app
#3351
Conversation
maxmoehl
force-pushed
the
feat/add-ready-column
branch
from
a60217e to
c6d4cdb
Compare
The tests were assuming that all timezone codes are three letters when there many timezones that have two or more than three letter codes.
CC version 3.144.0 introduced readiness checks and with them a new status field for processes: routable. This commit exposes that new field in the `cf app` command to allow users to easily determine the state of their application instances. See: https://github.com/cloudfoundry/capi-release/releases/tag/1.158.0
maxmoehl
force-pushed
the
feat/add-ready-column
branch
from
c6d4cdb to
a46f6c4
Compare
|
Hey |
|
@joaopapereira this would be a breaking change so I'm not sure whether we should continue with it. |
|
On the Broadcom side, we would like to have this feature in, so I think our best bet here is to move that to the last spot of the table so that we do not make this a breaking change and afterward we can continue the conversation about the UX changes of CLI, what do you think? @maxmoehl |
|
Sounds good to me. I'm not sure when I can pick this up again as I will be out next week. If you want to, I'm also fine with you cherry-picking my changes into a feature branch of your own and modifying them as needed (or developing this on your end, whatever makes more sense for you). |
|
I think I will cherry-pick this since I have some bandwidth |
|
I opened this pr #3429 |
|
Superseded by #3429 |
See #3350 for details.
Description of the Change
We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.
Why Is This PR Valuable?
What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?
Applicable Issues
List any applicable GitHub Issues here
How Urgent Is The Change?
Is the change urgent? If so, explain why it is time-sensitive.
Other Relevant Parties
Who else is affected by the change?