Skip to content

Feat: add ready column to cf app #3351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

maxmoehl
Copy link
Member

@maxmoehl maxmoehl commented Jan 7, 2025

See #3350 for details.

Description of the Change

We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.

Why Is This PR Valuable?

What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?

Applicable Issues

List any applicable GitHub Issues here

How Urgent Is The Change?

Is the change urgent? If so, explain why it is time-sensitive.

Other Relevant Parties

Who else is affected by the change?

@maxmoehl maxmoehl force-pushed the feat/add-ready-column branch from a60217e to c6d4cdb Compare January 14, 2025 10:12
The tests were assuming that all timezone codes are three letters when
there many timezones that have two or more than three letter codes.
CC version 3.144.0 introduced readiness checks and with them a new
status field for processes: routable. This commit exposes that new
field in the `cf app` command to allow users to easily determine the
state of their application instances.

See: https://github.com/cloudfoundry/capi-release/releases/tag/1.158.0
@maxmoehl maxmoehl force-pushed the feat/add-ready-column branch from c6d4cdb to a46f6c4 Compare January 18, 2025 11:32
@joaopapereira
Copy link
Contributor

Hey
Are you planning on getting this out of draft so that we can review and merge it?

@maxmoehl
Copy link
Member Author

@joaopapereira this would be a breaking change so I'm not sure whether we should continue with it.

@joaopapereira
Copy link
Contributor

On the Broadcom side, we would like to have this feature in, so I think our best bet here is to move that to the last spot of the table so that we do not make this a breaking change and afterward we can continue the conversation about the UX changes of CLI, what do you think? @maxmoehl

@maxmoehl
Copy link
Member Author

Sounds good to me.

I'm not sure when I can pick this up again as I will be out next week. If you want to, I'm also fine with you cherry-picking my changes into a feature branch of your own and modifying them as needed (or developing this on your end, whatever makes more sense for you).

@joaopapereira
Copy link
Contributor

I think I will cherry-pick this since I have some bandwidth

@joaopapereira
Copy link
Contributor

I opened this pr #3429

@maxmoehl
Copy link
Member Author

Superseded by #3429

@maxmoehl maxmoehl closed this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants