Skip to content

TEST - DO NOT MERGE #3504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Samze wants to merge 2 commits into from
Closed

TEST - DO NOT MERGE #3504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10ca60a
Remove explicit cli version check from plugin system
Samze May 12, 2025
95c88db
do not merge
Samze May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions actor/pluginaction/install.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import (
"sort"
"strings"

"github.com/blang/semver/v4"

"code.cloudfoundry.org/cli/actor/actionerror"
"code.cloudfoundry.org/cli/api/plugin"
"code.cloudfoundry.org/cli/util/configv3"
Expand Down Expand Up @@ -88,10 +86,6 @@ func (actor Actor) GetAndValidatePlugin(pluginMetadata PluginMetadata, commandLi
return configv3.Plugin{}, actionerror.PluginInvalidError{Err: err}
}

cliVersion, err := semver.Make(actor.config.BinaryVersion())
if err != nil {
return configv3.Plugin{}, actionerror.PluginInvalidError{Err: err}
}
var pluginLibraryMajorVersion int
hasPluginLibraryVersion := plugin.LibraryVersion != configv3.PluginVersion{}
if !hasPluginLibraryVersion {
Expand All @@ -100,13 +94,8 @@ func (actor Actor) GetAndValidatePlugin(pluginMetadata PluginMetadata, commandLi
pluginLibraryMajorVersion = plugin.LibraryVersion.Major
}

switch cliVersion.Major {
case 6, 7, 8:
if pluginLibraryMajorVersion > 1 {
return configv3.Plugin{}, actionerror.PluginInvalidLibraryVersionError{}
}
default:
panic("unrecognized major version")
if pluginLibraryMajorVersion > 1 {
return configv3.Plugin{}, actionerror.PluginInvalidLibraryVersionError{}
}

installedPlugins := actor.config.Plugins()
Expand Down
1 change: 1 addition & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import (
)

func main() {
fmt.Println("foooob")
var exitCode int
defer panichandler.HandlePanic()

Expand Down
Loading