fix: set poster-true only if no poster-options provided (#972)

Author: tsi

src/config/defaults.js

@@ -19,7 +19,6 @@ export default {
   textTrackSettings: false,
   loop: false,
   muted: false,
-  poster: true,
   posterOptions: {},
   sourceTypes: ['auto'],
   contextMenu: {

src/plugins/cloudinary/index.js

@@ -6,7 +6,8 @@ import {
   normalizeOptions,
   mergeTransformations,
   extendCloudinaryConfig,
-  setupCloudinaryMiddleware
+  setupCloudinaryMiddleware,
+  isRawUrl
 } from './common';
 import VideoSource from './models/video-source/video-source';
 import EventHandlerRegistry from './event-handler-registry';
@@ -127,12 +128,21 @@ class CloudinaryContext {
 
       const defaultPosterOptions = posterOptionsForCurrent();
       const userPosterOptions = options.posterOptions;
-      options.poster = options.poster || defaultPosterOptions;
+      const hasUserPosterOptions = userPosterOptions && Object.keys(userPosterOptions).length > 0;
+      
+      if (options.poster === undefined) {
+        if (isRawUrl(publicId)) {
+          options.poster = false;
+        } else if (!hasUserPosterOptions) {
+          options.poster = true;
+        }
+      }
+      
       options.posterOptions = Object.assign(
         {},
         defaultPosterOptions,
         userPosterOptions,
-        { hasUserPosterOptions: !!userPosterOptions || null }
+        { hasUserPosterOptions: hasUserPosterOptions || null }
       );
 
       options.queryParams = Object.assign(options.queryParams || {}, options.allowUsageReport ? { _s: `vp-${VERSION}` } : {});

src/plugins/cloudinary/models/video-source/video-source.js

@@ -39,7 +39,7 @@ class VideoSource extends BaseSource {
       options.resource_type = options.resourceType;
     }
 
-    if (!options.poster) {
+    if (options.poster === undefined) {
       options.poster = Object.assign({ publicId }, DEFAULT_POSTER_PARAMS);
     }