Skip to content

Fixes from phpstan #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Fixes from phpstan #91

wants to merge 4 commits into from

Conversation

szepeviktor
Copy link

@szepeviktor szepeviktor commented May 29, 2020 •
edited
Loading

@DavidCramer Done :) 🍏

vendor/bin/phpcs --standard=WordPress-VIP-Go --exclude=WordPress.WP.TimezoneChange \
  cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/ \
  cloudinary-image-management-and-manipulation-in-the-cloud-cdn/cloudinary.php

as per Automattic/VIP-Coding-Standards#457

@szepeviktor
Fix almost all PHPStan Level 0 errors
e4fdea6
@szepeviktor
Fix all WordPress VIp requirements
70b1130 
```bash
vendor/bin/phpcs --standard=WordPress-VIP-Go --exclude=WordPress.WP.TimezoneChange \
  cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/ cloudinary-image-management-and-manipulation-in-the-cloud-cdn/cloudinary.php
```

as per Automattic/VIP-Coding-Standards#457
@szepeviktor szepeviktor changed the title Fixes/from phpstan Fixes from phpstan May 29, 2020
@DavidCramer
Copy link
Contributor

Thanks@szepeviktor ! I really appreciate it. I'll review this over the weekend!

@pereirinha
Copy link
Contributor

Thank you, @szepeviktor, for the PR.

I see value in integrating PHPStan as part of our CI, but we've been having issues as the plugin needs to be compatible with PHP 5.6.

For that reason, I'm closing this PR in favor of #391.

Perhaps you've some ideas on how to overcome the failed builds.

@pereirinha pereirinha closed this Sep 27, 2021
@szepeviktor
Copy link
Author

szepeviktor commented Sep 27, 2021 •
edited
Loading

Perhaps you've some ideas on how to overcome the failed builds.

Hello @pereirinha! CI should install PHPStan breaking PHP 5.6 compatibility.
As a new job: https://github.com/cloudinary/cloudinary_wordpress/blob/master/.travis.yml#L12
PHPStan is a modern, "non-WordPress" tool.

@szepeviktor szepeviktor deleted the fixes/from-phpstan branch September 27, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szepeviktor @DavidCramer @pereirinha