-
Notifications
You must be signed in to change notification settings - Fork 230
Open
Description
By stability, I mean having the rendered chart match the stored resources. Tools like ArgoCD will notice if the chart and the Kubernetes resources configured via the chart are out of sync. There are a few spots that have this problem. Fixes:
diff --git a/cnpg-plugin-wal-g/chart/templates/certificates.yaml b/cnpg-plugin-wal-g/chart/templates/certificates.yaml
index 10e40056..ac9fab93 100644
--- a/charts/cloudnative-pg-operator/charts/cnpg-plugin-wal-g/templates/certificates.yaml
+++ b/charts/cloudnative-pg-operator/charts/cnpg-plugin-wal-g/templates/certificates.yaml
@@ -10,7 +10,6 @@ spec:
commonName: cnpg-plugin-wal-g-client
duration: {{ .Values.cnpg.tls.certManager.certsDuration }}
renewBefore: {{ .Values.cnpg.tls.certManager.certsRenewBefore }}
- isCA: false
usages:
- client auth
issuerRef:
@@ -37,7 +36,6 @@ spec:
- {{ include "cnpg-plugin-wal-g.fullname" . }}
duration: {{ .Values.cnpg.tls.certManager.certsDuration }}
renewBefore: {{ .Values.cnpg.tls.certManager.certsRenewBefore }}
- isCA: false
usages:
- server auth
issuerRef:
and
diff --git a/cnpg-plugin-wal-g/chart/values.yaml b/cnpg-plugin-wal-g/chart/values.yaml
index 90e2d1d1..1b9d983f 100644
--- a/charts/cloudnative-pg-operator/charts/cnpg-plugin-wal-g/values.yaml
+++ b/charts/cloudnative-pg-operator/charts/cnpg-plugin-wal-g/values.yaml
@@ -9,8 +9,8 @@ cnpg:
existingIssuerName: ""
createServerCert: true
createClientCert: true
- certsDuration: 43800h # 5 years (5 * 365 * 24 hours)
- certsRenewBefore: 8760h # 1 year (365 * 24 hours)
+ certsDuration: 43800h0m0s # 5 years (5 * 365 * 24 hours)
+ certsRenewBefore: 8760h0m0s # 1 year (365 * 24 hours)
# Number of replicas for plugin controller-manager deployment
I can make a pull request if you'd like, but these are such tiny changes maybe a maintainer will just adopt them?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels