Support --master without --kubeconfig #1859
Open
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qbnit0
force-pushed
the
incluster-with-master
branch
from
f63f76f to
560dcd4
Compare
If --master is specified, but --kubeconfig is not, use in-cluster config and override the host. Previous behaviour was to use out-of-cluster config anyway (and fail).
qbnit0
force-pushed
the
incluster-with-master
branch
from
560dcd4 to
6d2566f
Compare
|
Just did a quick test, works as expected. |
|
Let me know if I need to change the if-elseif-else to a switch to appease gocritic. An if-elseif-else seems more logical to me here, though. |
|
Thanks for submitting this! I'll try to take a look soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If --master is specified, but --kubeconfig is not, use in-cluster config and override the API server host.
This would fix #1614.