Skip to content

Conversation

pablotp
Copy link

@pablotp pablotp commented May 12, 2025

what

  • Ignore the changes made to the global-secondary-index.

why

  • Changes made to the global_secondary_index.read|write_capacity by the autoscaler causes drift.

references

@pablotp pablotp requested review from a team as code owners May 12, 2025 11:40
@mergify mergify bot added the triage Needs triage label May 12, 2025
@pablotp
Copy link
Author

pablotp commented May 12, 2025

/terratest

@pablotp pablotp force-pushed the allow-ignoring-gsi-changes branch 4 times, most recently from 64f3805 to 20452fd Compare May 12, 2025 12:25
@pablotp pablotp changed the title feat: Allow ignoring GSI changes feat: Ignore GSI changes May 12, 2025
@pablotp pablotp force-pushed the allow-ignoring-gsi-changes branch from 20452fd to 50b50d9 Compare May 12, 2025 12:27
@RoseSecurity
Copy link

Until the provider addresses this bug, this situation appears fair. We might need to add a README note to document that setting this option means Terraform will ignore any changes to GSIs and require manual or automated application.

@pablotp
Copy link
Author

pablotp commented May 19, 2025

Until the provider addresses this bug, this situation appears fair. We might need to add a README note to document that setting this option means Terraform will ignore any changes to GSIs and require manual or automated application.

Sounds good 👍🏻
I've just pushed aa6c434
Please let me know whether or not it meets your expectations. I generated the README.d using make readme, and it added a couple of unrelated changes (mainly replacing <br> with <br/>).

Copy link

mergify bot commented Jun 11, 2025

💥 This pull request now has conflicts. Could you fix it @pablotp? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Jun 11, 2025
@pablotp pablotp force-pushed the allow-ignoring-gsi-changes branch from aa6c434 to 0d22a4c Compare June 11, 2025 13:17
@mergify mergify bot removed the conflict This PR has conflicts label Jun 11, 2025
@RoseSecurity
Copy link

/terratest

I can't think of any alternative solutions to this issue, but I'd love to get a second set of eyes from the team on this change.

@pablotp
Copy link
Author

pablotp commented Jul 7, 2025

I can't think of any alternative solutions to this issue, but I'd love to get a second set of eyes from the team on this change.

Right now, I can't either.
After using this solution for a bit, I must admit that it gets tricky when you need to make changes apart from read|write_capacity (e.g., new secondary indexes). Therefore, I feel like this issue needs a solution at the provider level hashicorp/terraform-provider-aws#671.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Needs triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants