Skip to content

feat: add source_ip_allow_list_s3_objects #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add source_ip_allow_list_s3_objects #270

wants to merge 2 commits into from

Conversation

nitrocode
Copy link
Member

what

  • feat: add source_ip_allow_list_s3_objects

why

  • Prevent S3 lock out by allowing IP addresses to block only object level permissions

references

@nitrocode nitrocode requested review from a team as code owners April 3, 2025 22:32
@nitrocode nitrocode requested review from Gowiem and RoseSecurity April 3, 2025 22:32
@mergify mergify bot added the triage Needs triage label Apr 3, 2025
@nitrocode
feat: add var.source_ip_allow_list_s3_objects
3aeb54b 
Signed-off-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
@nitrocode nitrocode force-pushed the ip-prevent-lock-out branch from f2b5284 to 3aeb54b Compare April 3, 2025 22:34
@nitrocode
Copy link
Member Author

/terratest

@nitrocode nitrocode changed the title feat: add source_ip_allow_list_s3_objects feat: add source_ip_allow_list_s3_objects Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@RoseSecurity RoseSecurity Awaiting requested review from RoseSecurity RoseSecurity is a code owner automatically assigned from cloudposse/contributors

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
triage Needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The statement for var.source_ip_allow_list includes s3:PutBucketPolicy which locks user out of the bucket
1 participant
@nitrocode