-
Notifications
You must be signed in to change notification settings - Fork 178
Add simple reionization heating model #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Add include_heating flag to TReionizationModel (default True) - Smoothly heat baryon temperature from recombination value to ~1e4K following x_e shape - Map baryon sound speed from original formula to ideal gas cs^2 = gamma kT/(mu mp) - Preserves original behavior before reionization, transitions smoothly during - Addresses issue #181 with leading-order correction for reionization effects
|
Is the |
|
I suppose that technically the sound speed equation you had originally is always correct (although it neglects the time evolution of the mean molecular weight, which !=0 during reionization), so the ideal gas formula with γ=5/3 is only true when Tb is evolving adiabatically, i.e. neglecting the Compton cooling which is happening even after reionization has ended. But perhaps that is negligible as it's proportional to the CMB energy density, falling as (1+z)^4? Or maybe it was that term that was causing the issue in the first place. |
|
The model is certainly physically wrong in various ways, though not obviously wrong order of magnitude? detailed_heating_analysis.py |
|
OK, the plotting looks fine. I was surprised because I was only seeing changes to P(k) at k > 100 h/Mpc, not the k=1 h/Mpc scales you find here. But the Jeans scale for baryons after reionization is of order 10 h/Mpc, so that makes sense. Chatting to reionization people here, your simple model for T(z) is fine at the order of magnitude level. |
…zationModel; use it in results and avoid heating before reionization. Remove stray blank line. [AI agent]


This PR implements a simple reionization heating model to address issue #181.
Changes
include_heatingflag toTReionizationModel(defaultTrue)T_bis smoothly heated from the recombination value to ~10^4 K following the reionization ionization fractionx_eshapecs^2 = γ k_B T / (μ m_p)with γ=5/3cs^2calculation. During reionization, it smoothly interpolates to the heated model.Implementation Details
The heating weight
yheatfollows the reionization progression:The final quantities are:
This provides a leading-order correction for reionization effects on the matter power spectrum while maintaining backward compatibility.
Testing
The implementation has been tested with matter power spectrum calculations showing the expected suppression on small scales due to increased baryon pressure during reionization.
Closes #181
Pull Request opened by Augment Code with guidance from the PR author