Skip to content

Commit 0055132

Browse files
committed
Improve logic for freezing and unfreezing disassiotiated parameters
This functionality is intended to be upstreamed to RooFit, and therefore refactored in one portable function that can be moved to the RooFit helpers. The major change is that the function that freezes the parameters now returns a set with all parameters where the constant change was toggled. This allows us to easily un-freeze these parameters later, without having to carry around in the global state the full list of original floating parameters
1 parent 4dcda26 commit 0055132

File tree

5 files changed

+116
-163
lines changed

5 files changed

+116
-163
lines changed

interface/CascadeMinimizer.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ class RooAbsReal;
55
class RooArgSet;
66
class RooRealVar;
77
#include <RooArgSet.h>
8-
#include <RooListProxy.h>
9-
#include <RooSetProxy.h>
108
#include "RooMinimizer.h"
119
#include <boost/program_options.hpp>
1210

@@ -34,7 +32,6 @@ class CascadeMinimizer {
3432
static const boost::program_options::options_description & options() { return options_; }
3533
void trivialMinimize(const RooAbsReal &nll, RooRealVar &r, int points=100) const ;
3634
//void collectIrrelevantNuisances(RooAbsCollection &irrelevant) const ;
37-
bool freezeDiscParams(const bool);
3835
void setAutoBounds(const RooArgSet *pois) ;
3936
void setAutoMax(const RooArgSet *pois) ;
4037
double tolerance() {return defaultMinimizerTolerance_;};
@@ -126,7 +123,6 @@ class CascadeMinimizerGlobalConfigs{
126123
RooArgList nuisanceParameters;
127124
RooArgList allFloatingParameters;
128125
RooArgList parametersOfInterest;
129-
RooArgList allRooMultiPdfParams;
130126
RooArgList allRooMultiPdfs;
131127

132128
static CascadeMinimizerGlobalConfigs& O(){

interface/utils.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,6 @@ namespace utils {
121121
std::vector<std::vector<int> > generateOrthogonalCombinations(const std::vector<int> &vec);
122122
int countFloating(const RooArgSet &);
123123
RooArgSet returnAllVars(RooWorkspace *);
124-
bool freezeAllDisassociatedRooMultiPdfParameters(const RooArgSet & multiPdfs, const RooArgSet & allRooMultiPdfParams, bool freeze=true);
125124

126125
}
127126

0 commit comments

Comments
 (0)