Skip to content

Improve logic for freezing and unfreezing disassiotiated parameters #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve logic for freezing and unfreezing disassiotiated parameters #1107

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0055132
Improve logic for freezing and unfreezing disassiotiated parameters
guitargeek Jul 23, 2025
7679114
Update src/CascadeMinimizer.cc
anigamova Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions interface/CascadeMinimizer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ class RooAbsReal;
class RooArgSet;
class RooRealVar;
#include <RooArgSet.h>
#include <RooListProxy.h>
#include <RooSetProxy.h>
#include "RooMinimizer.h"
#include <boost/program_options.hpp>

Expand Down Expand Up @@ -34,7 +32,6 @@ class CascadeMinimizer {
static const boost::program_options::options_description & options() { return options_; }
void trivialMinimize(const RooAbsReal &nll, RooRealVar &r, int points=100) const ;
//void collectIrrelevantNuisances(RooAbsCollection &irrelevant) const ;
bool freezeDiscParams(const bool);
void setAutoBounds(const RooArgSet *pois) ;
void setAutoMax(const RooArgSet *pois) ;
double tolerance() {return defaultMinimizerTolerance_;};
Expand Down Expand Up @@ -126,7 +123,6 @@ class CascadeMinimizerGlobalConfigs{
RooArgList nuisanceParameters;
RooArgList allFloatingParameters;
RooArgList parametersOfInterest;
RooArgList allRooMultiPdfParams;
RooArgList allRooMultiPdfs;

static CascadeMinimizerGlobalConfigs& O(){
Expand Down
1 change: 0 additions & 1 deletion interface/utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ namespace utils {
std::vector<std::vector<int> > generateOrthogonalCombinations(const std::vector<int> &vec);
int countFloating(const RooArgSet &);
RooArgSet returnAllVars(RooWorkspace *);
bool freezeAllDisassociatedRooMultiPdfParameters(const RooArgSet & multiPdfs, const RooArgSet & allRooMultiPdfParams, bool freeze=true);

}

Expand Down
Loading
Loading