-
Notifications
You must be signed in to change notification settings - Fork 823
Honor Guard QoL #10929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Syndro101
wants to merge
10
commits into
cmss13-devs:master
Choose a base branch
from
Syndro101:HonorGuard-QOL
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Honor Guard QoL #10929
+442
−319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2fa6459: maps/map_files/USS_Almayer/USS_Almayer.dmm Automatically commited by: tools\mapmerge2\fixup.py
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code Improvement
Make the code longer
Feature
Feature coder badge
Mapping
did you remember to save in tgm format?
size/L
Denotes a PR that changes 200-799 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Explain why it's good for the game
With Honor Guards no longer restricted to Commanding Officers, their potential use has expanded, as such I think the antiquated safe and kit loadout is in need of replacement.
Letting Honor Guard Candidates gear up with a vendor in CIC saves quite a lot of time, which can usually be the difference between making a drop and missing it.
One of the current issues is that the safe is only openable by the Commanding Officer... who isn't always in a round. This leads to the awkward practice of shooting the damn thing until it breaks™, which both takes time, potential IFF and concerned radio messages from the rest of the crew.
I've also noticed that when Honor Guards are called upon, quite a few are less than intrigued to step up, I believe that a varied selection in loadout will bring more interest to the role and generally be more fun for those occupying the role.
Regarding map changes
The changes are overall very minor, the CIC armory has had its shutter widened by 1 tile, which is useful if you have 2 Staff Officers gearing up at the same time.
I fixed some outdated tiles near research that belonged to the old ladders, along with the semiotics that were never removed.
Ditto as above for the CL's office, northern maintenance door.
I edited some layers on some items in CIC and moved clutter around, you'd likely never notice.
If you do want to see all the changes, look at checks for mapbot.
Regarding balance
The only thing this allows for balance-wise is more than 2 legitimate honor guards. However, I highly doubt this will be an issue as:
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑
add: added a vendor for MP Honor Guards
mapadd: added an Honor Guard Vendor to CIC Armory
maptweak: tweaked CIC Armories to be less cramped, fixed some misplaced tiling and semiotics
/:cl: