Reworks assignment identification for sec HUDs#11695
Open
Puckaboo2 wants to merge 1 commit intocmss13-devs:masterfrom
Open
Reworks assignment identification for sec HUDs#11695Puckaboo2 wants to merge 1 commit intocmss13-devs:masterfrom
Puckaboo2 wants to merge 1 commit intocmss13-devs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
Part 2 of atomizing #11382
Changes have been tested.
Explain why it's good for the game
The code for security HUDs identifying a mob's assignment predated the radio faction-related hud system we have today, resulting in double hud icons. I removed the extraneous icons and replaced them with a more practical system because we can already identify a person's assignment if they're within our faction group--and if they're not, tough beans, ask them.
This system is much more simple for people to understand. If a person's assignment cannot be identified because they are not within our faction, check the status of their ID. If it's green, yay. If red, that's somebody else's ID and that person should be investigated; if grey, they need an ID.
Screenshots & Videos
Changelog
🆑 Puckaboo2
add: Adds a feature for sec HUDs that identifies whether a person is holding their own ID, somebody else's ID, or no ID at all for authentication and authorization purposes.
code: Deleted a handful of lines of code and replaced one-variable vars when possible.
fix: Fixes the issue where the sec HUD says the person does not have a viable assignment despite showing up on the radio's faction HUD feature.
imageadd: Adds new hud icons for security HUDs based on whether a person is holding their own card, somebody else's card, or has no card at all.
imagedel: Removes the assignment-related overlays on sec HUDs.
/:cl: