Migrate Zend Framework integration to Laminas

[loco8878]

No description provided.

[loco8878]

Hi guys, can you do a review here?

The pull request is for this ticket

[florianeckerstorfer]

Looks to me (although I haven't used Laminas, I have to trust that the tests do their job ;) ) Just one small missed ZF2 → Laminas change and please remove the ZF2 section from the readme.

[florianeckerstorfer]

@loco8878 And thank you very much for the PR 🎉

[froschdesign]

Unfortunately, the implementation is not correct. Some things have been forgotten and some are too much. The packages for the module manager and the service manager, for example, are not required.

[froschdesign]

I can do a review, but unfortunately not immediately.

[froschdesign]

I suggest to extend the Composer configuration and add the module and config provider because this allows the usage of laminas-component-installer. Which is a Composer plugin for injecting modules and configuration providers into application configuration for laminas-mvc based applications and Mezzio applications.

• https://docs.laminas.dev/laminas-component-installer/#modules
• https://docs.laminas.dev/laminas-component-installer/#config-providers

[froschdesign]

Here is another suggestion: #261 (comment)

[loco8878]

Here is another suggestion: #261 (comment)

Input filter is added

[florianeckerstorfer]

@froschdesign Could you take a quick look at the updated PR and check if it looks good now? Thank you so much in advance

[loco8878]

@froschdesign Can you please review this PR again? Many thanks.

[loco8878]

@froschdesign Can you please review this PR again? Many thanks.

[florianeckerstorfer]

It's been a while, @loco8878 do you think I can go ahead and merge it?

[loco8878]

@florianeckerstorfer Fine by me. @froschdesign ?

[froschdesign]

@loco8878
Unfortunately, I do not understand why the ‘Service’ class exists at all. I therefore propose the following changes:

• remove the SlugifyService (maybe a BC break!)
• allow the configuration of the filter via config:
  • create a factory
  • check for explicit filter options
  • check for general cocur_slugify options
  • otherwise create the filter without options (the filter already has standard options)
• allow the configuration of the view helper via config:
  • create a factory
  • check for explicit view helper options
  • check for general cocur_slugify options
  • otherwise create the view helper without options (the view helper should have standard options)

---

Please also note that there is a new major version of laminas-filter: https://docs.laminas.dev/laminas-filter/v3/migration/v2-to-v3/