Skip to content

communication style classifier #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 17, 2023

Conversation

LeonardPuettmannKern
Copy link
Contributor

@LeonardPuettmannKern LeonardPuettmannKern commented Oct 16, 2023

refinery

  • Tested by creator on refinery
  • Tested by reviewer on refinery
  • Ensured that output of brick conforms with refinery structure (to be checked by reviewer)

API

  • Tested by creator on localhost:8000/docs
  • Tested by reviewer on localhost:8000/docs

common code

  • Common code tested in notebook/ script by creator
  • Common code tested in notebook/ script by reviewer
  • Common code contains docstrings and type hints

additional points:

  • Docstring and README is existing
  • Import statements (in __init__.py)
  • (If necessary) Added dependency to requirements.txt
  • (If necessary) Added dependency to issue for refinery env here
  • Published brick to Strapi CMS (locally)

@FelixKirschKern some notes:

  • I went for the group name "query_check". There might be a more fitting name however. -> I suggest "query_type"
  • For the example endpoint, the request_url is hardcoded. Would it be correct to assume that for this, we only want to offer the free endpoint? -> yes atm hardcoded is good
  • The name of the model should be a parameter IMO, as we might offer multiple versions of this model in the future. -> could make sense to have different options in the future yes, but could we not change it then, I think then we would also provide the options
  • Future versions of this model should maybe have a label for "unknown"? -> is unknown not somehow included in the score, so we could also decide to return no label if the score of the model is too low

Adds #352

@LeonardPuettmannKern LeonardPuettmannKern changed the title communication style classifier (placeholder) communication style classifier Oct 16, 2023
@LeonardPuettmannKern LeonardPuettmannKern marked this pull request as ready for review October 16, 2023 15:25
@LeonardPuettmannKern LeonardPuettmannKern merged commit 24bebe5 into main Oct 17, 2023
@LeonardPuettmannKern LeonardPuettmannKern deleted the communication-style-classifier branch October 17, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants