Skip to content

Maximum sentence complexity #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Maximum sentence complexity #379

merged 3 commits into from
Oct 23, 2023

Conversation

LeonardPuettmannKern
Copy link
Contributor

@LeonardPuettmannKern LeonardPuettmannKern commented Oct 17, 2023

refinery

  • Tested by creator on refinery
  • Tested by reviewer on refinery
  • Ensured that output of brick conforms with refinery structure (to be checked by reviewer)

API

  • Tested by creator on localhost:8000/docs
  • Tested by reviewer on localhost:8000/docs

common code

  • Common code tested in notebook/ script by creator
  • Common code tested in notebook/ script by reviewer
  • Common code contains docstrings and type hints

additional points:

  • Docstring and README is existing
  • Import statements (in __init__.py)
  • (If necessary) Added dependency to requirements.txt
  • (If necessary) Added dependency to issue for refinery env here
  • Published brick to Strapi CMS (locally)

Testing procedure:
When testing in refinery, please ensure that the output of the brick conforms with the structure of refinery.
For extraction bricks, this would be a tuple like ("label", span_start, span_end).
For classification bricks, this would be a string representing a label.
For generator bricks, this would either be a float, interger, string, boolean or a list, depending on the situation.

When testing the bricks, try to avoid using only one source of data. Meaning that you should not only use the clickbait sample
project, but also different texts with longer or more complex strings.

A small refinery example project with a variation of texts called bricks-test-data-project.zip can be found in the bricks repository.

Implements #378

@FelixKirschKern FelixKirschKern merged commit c22cfb6 into main Oct 23, 2023
@FelixKirschKern FelixKirschKern deleted the max-sentence-complexity branch October 23, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants