Skip to content

Fix duplicate downloads #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025
Merged

Fix duplicate downloads #174

merged 2 commits into from
Apr 28, 2025

Conversation

matejchalk
Copy link
Contributor

@matejchalk matejchalk commented Apr 28, 2025

Should fix various JSON.parse errors in monorepo mode when downloaded artifacts from previous run are read by compare command. The artifacts are downloaded in parallel, so may conflict with each other. The requests to GitHub API are also duplicated for each project - replaced with in-memory cache of downloaded files.

Copy link

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 94bfe6a with previous commit 5b58a9c.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Security 🔴 33 🔴 49 ↑ +15.8
Updates 🟢 98 🟢 97 ↓ −1.2
Code coverage 🟡 58 🟡 58 ↑ +0.6
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 2 groups improved, 👎 1 group regressed, 👍 4 audits improved, 👎 2 audits regressed, 1 audit changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JS Packages NPM audit 🔴 33 🔴 49 ↑ +15.8
JS Packages NPM outdated dependencies 🟢 98 🟢 97 ↓ −1.2
Code coverage Code coverage metrics 🟡 58 🟡 58 ↑ +0.6

9 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JS Packages Vulnerabilities for NPM dev dependencies. 🟨 5 vulnerabilities (5 moderate) 🟩 1 vulnerability (1 moderate) ↓ −80 %
JS Packages Vulnerabilities for NPM prod dependencies. 🟥 13 vulnerabilities (2 high, 11 moderate) 🟥 10 vulnerabilities (2 high, 8 moderate) ↓ −23.1 %
JS Packages Outdated NPM dev dependencies. 🟨 3 major outdated package versions 🟨 13 outdated package versions (5 major, 6 minor, 2 patch) ↑ +333.3 %
Code coverage Function coverage 🟨 67.9 % 🟨 69 % ↑ +1.6 %
Code coverage Line coverage 🟨 56.4 % 🟨 57.2 % ↑ +1.5 %
Code coverage Branch coverage 🟥 37.7 % 🟥 37 % ↓ −1.7 %
JS Packages Outdated NPM prod dependencies. 🟩 all dependencies are up to date 🟩 2 patch outdated package versions ↑ +∞ %

165 other audits are unchanged.

@matejchalk matejchalk self-assigned this Apr 28, 2025
@matejchalk matejchalk added bug Something isn't working github_actions Pull requests that update GitHub Actions code labels Apr 28, 2025
@matejchalk matejchalk requested a review from vmasek April 28, 2025 12:48
@matejchalk matejchalk merged commit 0ce6883 into main Apr 28, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants