Skip to content

Commit 1cf02b2

Browse files
eps1loncursoragent
andauthored
[test] Skip failing segment-cache deploy test (vercel#90601)
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
1 parent 420560d commit 1cf02b2

File tree

1 file changed

+68
-64
lines changed

1 file changed

+68
-64
lines changed

test/e2e/app-dir/segment-cache/basic/segment-cache-basic.test.ts

Lines changed: 68 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { createRouterAct } from 'router-act'
33
import { waitFor } from 'next-test-utils'
44

55
describe('segment cache (basic tests)', () => {
6-
const { next, isNextDev } = nextTestSetup({
6+
const { next, isNextDev, isNextDeploy } = nextTestSetup({
77
files: __dirname,
88
})
99
if (isNextDev) {
@@ -277,71 +277,75 @@ describe('segment cache (basic tests)', () => {
277277
expect(await dynamicDiv.innerHTML()).toBe('Dynamic page')
278278
})
279279

280-
it('refreshes page segments when navigating to the exact same URL as the current location', async () => {
281-
let act: ReturnType<typeof createRouterAct>
282-
const browser = await next.browser('/same-page-nav', {
283-
beforePageLoad(page) {
284-
act = createRouterAct(page)
285-
},
286-
})
287-
288-
const linkWithNoHash = await browser.elementByCss(
289-
'a[href="/same-page-nav"]'
290-
)
291-
const linkWithHashA = await browser.elementByCss(
292-
'a[href="/same-page-nav#hash-a"]'
293-
)
294-
const linkWithHashB = await browser.elementByCss(
295-
'a[href="/same-page-nav#hash-b"]'
296-
)
297-
298-
async function readRandomNumberFromPage() {
299-
const randomNumber = await browser.elementById('random-number')
300-
return await randomNumber.textContent()
301-
}
302-
303-
// Navigating to the same URL should refresh the page
304-
const randomNumber = await readRandomNumberFromPage()
305-
await act(async () => {
306-
await linkWithNoHash.click()
307-
}, [
308-
{
309-
includes: 'random-number',
310-
},
311-
{
312-
// Only the page segments should be refreshed, not the layouts.
313-
// TODO: We plan to change this in the future.
314-
block: 'reject',
315-
includes: 'same-page-nav-layout',
316-
},
317-
])
318-
const randomNumber2 = await readRandomNumberFromPage()
319-
expect(randomNumber2).not.toBe(randomNumber)
320-
321-
// Navigating to a different hash should *not* refresh the page
322-
await act(async () => {
323-
await linkWithHashA.click()
324-
}, 'no-requests')
325-
expect(await readRandomNumberFromPage()).toBe(randomNumber2)
326-
327-
// Navigating to the same hash again should refresh the page
328-
await act(
329-
async () => {
330-
await linkWithHashA.click()
331-
},
332-
{
333-
includes: 'random-number',
280+
// TODO: Fix same-page navigation refresh behavior in deploy mode
281+
;(isNextDeploy ? it.skip : it)(
282+
'refreshes page segments when navigating to the exact same URL as the current location',
283+
async () => {
284+
let act: ReturnType<typeof createRouterAct>
285+
const browser = await next.browser('/same-page-nav', {
286+
beforePageLoad(page) {
287+
act = createRouterAct(page)
288+
},
289+
})
290+
291+
const linkWithNoHash = await browser.elementByCss(
292+
'a[href="/same-page-nav"]'
293+
)
294+
const linkWithHashA = await browser.elementByCss(
295+
'a[href="/same-page-nav#hash-a"]'
296+
)
297+
const linkWithHashB = await browser.elementByCss(
298+
'a[href="/same-page-nav#hash-b"]'
299+
)
300+
301+
async function readRandomNumberFromPage() {
302+
const randomNumber = await browser.elementById('random-number')
303+
return await randomNumber.textContent()
334304
}
335-
)
336-
const randomNumber3 = await readRandomNumberFromPage()
337-
expect(randomNumber3).not.toBe(randomNumber2)
338305

339-
// Navigating to a different hash should *not* refresh the page
340-
await act(async () => {
341-
await linkWithHashB.click()
342-
}, 'no-requests')
343-
expect(await readRandomNumberFromPage()).toBe(randomNumber3)
344-
})
306+
// Navigating to the same URL should refresh the page
307+
const randomNumber = await readRandomNumberFromPage()
308+
await act(async () => {
309+
await linkWithNoHash.click()
310+
}, [
311+
{
312+
includes: 'random-number',
313+
},
314+
{
315+
// Only the page segments should be refreshed, not the layouts.
316+
// TODO: We plan to change this in the future.
317+
block: 'reject',
318+
includes: 'same-page-nav-layout',
319+
},
320+
])
321+
const randomNumber2 = await readRandomNumberFromPage()
322+
expect(randomNumber2).not.toBe(randomNumber)
323+
324+
// Navigating to a different hash should *not* refresh the page
325+
await act(async () => {
326+
await linkWithHashA.click()
327+
}, 'no-requests')
328+
expect(await readRandomNumberFromPage()).toBe(randomNumber2)
329+
330+
// Navigating to the same hash again should refresh the page
331+
await act(
332+
async () => {
333+
await linkWithHashA.click()
334+
},
335+
{
336+
includes: 'random-number',
337+
}
338+
)
339+
const randomNumber3 = await readRandomNumberFromPage()
340+
expect(randomNumber3).not.toBe(randomNumber2)
341+
342+
// Navigating to a different hash should *not* refresh the page
343+
await act(async () => {
344+
await linkWithHashB.click()
345+
}, 'no-requests')
346+
expect(await readRandomNumberFromPage()).toBe(randomNumber3)
347+
}
348+
)
345349

346350
it('does not throw an error when navigating to a page with a server action', async () => {
347351
let act: ReturnType<typeof createRouterAct>

0 commit comments

Comments
 (0)