[pull] canary from vercel:canary #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What? This PR ensures we first clean the `.next/standalone` folder before writing into it. Currently the order is: 1. Write package.json to `.next/standalone/package.json` 1. Delete `.next/standalone` 1. Check `.nft.json` files and write the files listed there to `.next/standalone` Which in turn causes the package.json to not exist. So why does this not fail with webpack? Well, what I found is that the `_app` `.nft.json` file somehow lists the project root `package.json` even though it does not use it. This means that after we delete `.next/standalone` the `package.json` will still end up in the eventual directory regardless. It fails with Turbopack because Turbopack correctly does not include the package.json (as it's not used) and then the `package.json` is missing at runtime, causing the `server.js` which uses ESM to fail (because the detection for ESM is still valid regardless of deleting the folder). New order is: 1. Delete `.next/standalone` 1. Write package.json to `.next/standalone/package.json` 1. Check `.nft.json` files and write the files listed there to `.next/standalone`
…pe instead of the value for client-boundary warnings (#79193) Best be reviewed with "Hide whitespace". ### Why? Since it was matching `ts.isObjectBindingPattern`, which checks only the destructured props:  It didn't handle non-destructured:  Therefore, I think it's more natural to target the types, not the props value, as the cause of this warning is actually the types:   x-ref: #79144 (comment) --------- Co-authored-by: Janka Uryga <lolzatu2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )