[pull] canary from vercel:canary #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Adjusts the default timeouts: - elementByCss: 5s - waitForElementByCss: 10s Previously, we didn't pass an explicit value, so they both defaulted to playwright's default of 60s. This is _very_ slow, and if something is slow enough to require anything in that range, i'd say it deserves to be wrapped in `retry()` or something similar anyway, so it's fine to fail here. The upside of this is that errors because of bad selectors (or missing elements) happen faster, which is a nice thing, and might also save CI time. i could also see an argument for making these even shorter -- e.g. the default timeout for `retry()` is 3s, so maybe `retry` should be faster than that. https://github.com/vercel/next.js/blob/717e54b0cd914a17314c470cd10d6af2b2d75787/test/lib/next-test-utils.ts#L796-L799 but then again, `retry` doesn't factor in the time `fn` took, so these don't really conflict.
Reverts most of #78039, I've kept the applied clippy suggestions though. Unfortunately, a rustc ICE crash that was rare before now happens constantly, both when building and inside rust-analyzer, making everything just unusable.
This auto-generated PR updates the development integration test manifest used when testing Rspack.
This auto-generated PR updates the production integration test manifest used when testing Rspack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )