[pull] canary from vercel:canary #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…nt tasks in more places (#77760) Currently, we only do this check when a transient task is created for the first time. However (e.g. assuming buggy implementations of `TaskInput`, use of `turbo_tasks::State`, etc) it's possible that a persistent function does not create a transient task, but does read from cached data. In these cases, you wouldn't see the issue in development or in most e2e tests. Instead, you'd see panics after cache eviction (not yet on-by-default) or a restart of turbopack (as we cannot persistently cache transient tasks). This tries to catch such potential issues earlier, so that we can catch them before they get to users. This codepath is hot, but the check is very cheap: it's just checking the upper bit of two `u32`s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )