[pull] canary from vercel:canary #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
missing required tags error is a general error now, we don't need to have these custom type anymore
…78237) PR #77213 introduced replacing the custom language service and host with the `@typescript/vfs` package. It did improve performance for large codebases, but it is still a problem when the plugin is initialized multiple times with multiple virtual language services from multiple apps, resulting in **freezing the IDE**. Why did we need the "virtual language service" in the first place? It was to support features like providing completions and diagnostics for metadata export without explicitly setting the type. To achieve this, we stored a copy of the file in the virtual language service with the additional type: ```diff - export const metadata = {} + export const metadata: Metadata | null = {} ``` However, the trade-off loss is big compared to the win, and it can easily be replaced by importing the actual type — which is rational. We should carefully reconsider the support details and revisit the improvement. It could be a combination of semantic suggestion/warning to add type and auto-importing. As the first step, this PR removes the `@typescript/vfs` package and the metadata plugin features that depend on it.
Follow up of #78237 Auto import the `Metadata` type when completing the `metadata` and `generateMetadata` option. - If there is a `'use ...'` top directive, add import below the directive. - If there is an existing Metadata import, do not add another import. - This includes aliases as well. https://github.com/user-attachments/assets/5ea1ce7e-2320-41f0-ba33-af7568bbdd11
Follow up of #78237, #78258 If the exports of metadata options are missing types, warn them to import type to prevent breaking the app from invalid metadata. The warning covers: - `metadata` export - `generateMetadata` export - as function - as async function - as arrow function - as async arrow function - as function expression - as async function expression - all of the above as `export { ... }` https://github.com/user-attachments/assets/a25f9734-0d36-4592-a6fb-71faa7c00dbd --------- Co-authored-by: Sebastian "Sebbie" Silbermann <sebastian.silbermann@vercel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )