Skip to content

Pin Input #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Pin Input #338

wants to merge 7 commits into from

Conversation

raphael-goetz
Copy link
Member

Resolves: #239

@raphael-goetz raphael-goetz requested a review from nicosammito June 9, 2025 09:20
Copy link
Contributor

github-actions bot commented Jun 9, 2025

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/pictor/-/pipelines/1862981206

Status: Passed
Duration: 2 minutes

Job summaries

storybook:build

Storybook available at https://code0-tech.gitlab.io/-/development/pictor/-/jobs/10309113694/artifacts/storybook-static/index.html

Copy link
Contributor

@nicosammito nicosammito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the code review we have some functionality problems.
When I place AB1234 into the splitted PinInput some values are stuck and can't be removed.

Bildschirmfoto 2025-06-09 um 23 51 42

And I can't input uppercase characters into the normal PinInput.

@raphael-goetz
Copy link
Member Author

Alright I'll fix it. Can you tell me how you got the Values stuck. I can't recreate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PinInput
2 participants