Enhance flow creation and validation process with new data types and settings

Knerio · Knerio · commit 457223f9b92b · 2025-05-29T02:31:12.000+02:00
diff --git a/app/graphql/mutations/namespaces/projects/flows/create.rb b/app/graphql/mutations/namespaces/projects/flows/create.rb
@@ -15,9 +15,6 @@ class Create < BaseMutation
           argument :flow, Types::Input::FlowInputType
 
           def resolve(project_id:, flow:, **params)
-            create_params = {}
-
-
             project = SagittariusSchema.object_from_id(project_id)
 
             if project.nil?
@@ -30,11 +27,27 @@ def resolve(project_id:, flow:, **params)
               return error('Invalid input type id')
             end
 
+            return_type = SagittariusSchema.object_from_id(flow.return_type)
+            if return_type.nil?
+              return error('Invalid return type id')
+            end
 
+            flow_type = SagittariusSchema.object_from_id(flow.flow_type)
+            if flow_type.nil?
+              return error('Invalid flow type id')
+            end
 
-
-
-
+            Namespaces::Projects::Flows::CreateService.new(
+              create_authentication(context[:current_user]),
+              namespace_project: project,
+              params: {
+                return_type: return_type,
+                input_type: input_type,
+                flow_type: flow_type,
+                starting_node: params[:starting_node],
+                settings: params[:settings] || [],
+              }
+            ).execute.to_mutation_response(success_key: :flow);
           end
 
           def error(message)
diff --git a/app/graphql/types/input/data_type_identifier_input_type.rb b/app/graphql/types/input/data_type_identifier_input_type.rb
@@ -5,7 +5,7 @@ module Input
     class DataTypeIdentifierInputType < Types::BaseInputObject
       description 'Input type for data type identifier'
 
-      argument :data_type_identifier, String, required: false,
+      argument :data_type_id, Types::GlobalIdType[::DataTypeIdentifier], required: false,
                                   description: 'Data type ID'
       argument :generic_key, String, required: false,
                                      description: 'Generic key value'
diff --git a/app/graphql/types/input/flow_setting_input_type.rb b/app/graphql/types/input/flow_setting_input_type.rb
@@ -6,7 +6,7 @@ class FlowSettingInputType < Types::BaseInputObject
       description 'Input type for flow settings'
 
       argument :flow_setting_id, String, required: true,
-                                              description: 'The identifier of the flow setting'
+                                              description: 'The identifier (not database id) of the flow setting'
 
       argument :object, GraphQL::Types::JSON, required: true,
                                              description: 'The value of the flow setting'
diff --git a/app/graphql/types/input/generic_mapper_input_type.rb b/app/graphql/types/input/generic_mapper_input_type.rb
@@ -8,7 +8,7 @@ class GenericMapperInputType < Types::BaseInputObject
       argument :source, Types::Input::DataTypeIdentifierInputType, required: true,
                description: 'The source data type identifier for the mapper'
 
-      argument :target, Types::Input::DataTypeIdentifierInputType, required: true,
+      argument :target, String, required: true,
                 description: 'The target data type identifier for the mapper'
     end
   end
diff --git a/app/graphql/types/input/generic_type_input_type.rb b/app/graphql/types/input/generic_type_input_type.rb
@@ -5,7 +5,7 @@ module Input
     class GenericTypeInputType < Types::BaseInputObject
       description 'Input type for generic type operations.'
 
-      argument :data_type, Types::Input::DataTypeTypeInput, required: true, description: 'The data type associated with this generic type.'
+      argument :data_type_id, Types::GlobaIdType[::DataType], required: true, description: 'The data type associated with this generic type.'
       argument :generic_mappers, [Types::Input::GenericMapperInputType], required: true,
             description: 'The mappers associated with this generic type.'
 
diff --git a/app/services/namespaces/projects/flows/create_service.rb b/app/services/namespaces/projects/flows/create_service.rb
@@ -20,6 +20,22 @@ def execute
           end
 
           transactional do |t|
+            settings = []
+            params[:settings].each do |graphql_setting|
+              setting = FlowSetting.new(flow_setting_id: graphql_setting.flow_setting_id, object: graphql_setting.object)
+              unless setting.valid?
+                t.rollback_and_return! ServiceResponse.error(
+                  message: 'Invalid flow setting',
+                  payload: setting.errors
+                )
+                settings << setting
+              end
+            end
+            params[:settings] = settings
+
+            node = create_node_function(params[:starting_node], t)
+            params[:starting_node] = node
+
             flow = Flow.create(project: namespace_project, **params)
             unless flow.persisted?
               t.rollback_and_return! ServiceResponse.error(
@@ -50,6 +66,86 @@ def execute
             ServiceResponse.success(message: 'Created new project', payload: flow)
           end
         end
+
+        def create_node_function(node_function, t)
+          runtime_function_definition = SagittariusSchema.object_from_id(node_function.runtime_function_id)
+          if runtime_function_definition.nil?
+            t.rollback_and_return! ServiceResponse.error(
+              message: 'Invalid runtime function id',
+              payload: :invalid_runtime_function_id
+            )
+          end
+
+          params = []
+          node_function.parameters.each do |parameter|
+            runtime_parameter = SagittariusSchema.object_from_id(parameter.runtime_parameter_definition_id)
+            if runtime_parameter.nil?
+              t.rollback_and_return! ServiceResponse.error(
+                message: 'Invalid runtime parameter id',
+                payload: :invalid_runtime_parameter_id
+              )
+            end
+            if parameter.literal_value.present?
+              params << NodeParameter.create(
+                runtime_parameter: runtime_parameter,
+                literal_value: parameter.literal_value,
+              )
+              next
+            end
+            if parameter.function_value.present?
+              params << NodeParameter.create(
+                runtime_parameter: runtime_parameter,
+                function_value: create_node_function(parameter.function_value, t),
+              )
+              next
+            end
+            if parameter.reference_value.present?
+              identifier = parameter.reference_value.data_type_identifier
+
+              ReferenceValue.create(
+                reference_value_id: parameter.reference_value.reference_value_id,
+                data_type_identifier: get_data_type_identifier(identifier),
+              )
+            end
+
+          end
+
+          next_node = nil
+          if node_function.next_node.present?
+            next_node = create_node_function(node_function.next_node, t)
+          end
+
+
+          NodeFunction.create(
+            next_node: next_node,
+            runtime_function_definition: runtime_function_definition,
+            parameters: params
+          )
+        end
+
+        private
+
+        def get_data_type_identifier(identifier)
+          if identifier.generic_key.present?
+            return DataTypeIdentifier.create(generic_key: identifier.generic_key)
+          end
+
+          if identifier.generic_type.present?
+            data_type = SagittariusSchema.object_from_id(identifier.generic_type.data_type_id)
+            mappers = identifier.generic_type.mappers.map do |mapper|
+              GenericMapper.create(
+                generic_mapper_id: mapper.generic_mapper_id,
+                source: mapper.source,
+                target: mapper.target
+              )
+            end
+            return DataTypeIdentifier.create(generic_type: GenericType.create(data_type: data_type, mappers: mappers))
+          end
+
+          if identifier.data_type_id.present?
+            return DataTypeIdentifier.create(data_type: SagittariusSchema.object_from_id(identifier.data_type_id))
+          end
+        end
       end
     end
   end
diff --git a/app/services/namespaces/projects/flows/validation/data_type/data_type_validation_service.rb b/app/services/namespaces/projects/flows/validation/data_type/data_type_validation_service.rb
@@ -18,7 +18,7 @@ def initialize(current_authentication, flow, data_type)
             end
 
             def execute
-              logger.debug("Validating data type: #{data_type.name} for flow: #{flow.name}")
+              logger.debug("Validating data type: #{data_type.name} for flow: #{flow.id}")
 
               transactional do |t|
                 if data_type.invalid?
diff --git a/app/services/namespaces/projects/flows/validation/node_function/node_function_parameter_validation_service.rb b/app/services/namespaces/projects/flows/validation/node_function/node_function_parameter_validation_service.rb
@@ -41,6 +41,15 @@ def execute
                     flow,
                     parameter.reference_value
                   ).execute
+                  return
+                end
+                if parameter.function_value.present?
+                  logger.debug("Validating function value: #{parameter.function_value.id} for node parameter: #{parameter.id}")
+                  NodeFunctionValidationService.new(
+                    current_authentication,
+                    flow,
+                    parameter.function_value
+                  ).execute
                 end
               end
             end
diff --git a/app/services/namespaces/projects/flows/validation/validation_service.rb b/app/services/namespaces/projects/flows/validation/validation_service.rb
@@ -27,26 +27,30 @@ def execute
               # ---
               # Input Type Validation
               # ---
-              Namespaces::Projects::Flows::Validation::DataTypeValidationService(
-                current_authentication,
-                flow,
-                flow.input_type
-              ).execute
+              if flow.input_type.present?
+                Namespaces::Projects::Flows::Validation::DataType::DataTypeValidationService.new(
+                  current_authentication,
+                  flow,
+                  flow.input_type
+                ).execute
+              end
 
               # ---
               # Return Type Validation
               # ---
-              Namespaces::Projects::Flows::Validation::DataTypeValidationService(
-                current_authentication,
-                flow,
-                flow.return_type
-              ).execute
+              if flow.return_type.present?
+                Namespaces::Projects::Flows::Validation::DataType::DataTypeValidationService.new(
+                  current_authentication,
+                  flow,
+                  flow.return_type
+                ).execute
+              end
 
               # ---
               # Setting
               # ---
               flow.flow_settings.each do |setting|
-                Namespaces::Projects::Flows::Validation::FlowSettingValidationService(
+                Namespaces::Projects::Flows::Validation::FlowSettingValidationService.new(
                   current_authentication,
                   flow,
                   setting
@@ -56,12 +60,21 @@ def execute
               # ---
               # Starting node
               # ---
-              Namespaces::Projects::Flows::Validation::NodeFunctionValidationService(
+              Namespaces::Projects::Flows::Validation::NodeFunction::NodeFunctionValidationService.new(
                 current_authentication,
                 flow,
                 flow.starting_node
               ).execute
 
+              # ---
+              # Flow Type
+              # ---
+              FlowTypeValidationService.new(
+                current_authentication,
+                flow,
+                flow.flow_type
+              ).execute
+
               ServiceResponse.success(message: 'Validation service executed successfully', payload: flow)
             end
           end
diff --git a/db/structure.sql b/db/structure.sql
diff --git a/spec/services/namespaces/projects/flows/validation_service_spec.rb b/spec/services/namespaces/projects/flows/validation_service_spec.rb
