flow type structure #486

Knerio · 2025-05-28T16:12:11Z

close #500
close #420
close #388
close #475
close #401
close #462

github-actions · 2025-05-28T16:14:49Z

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/1856819960

Status: Passed
Duration: 4 minutes

Job summaries

rspec: [ee]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/10274492742/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/1856819960/test_report
Finished in 18.86 seconds (files took 12.97 seconds to load)
1131 examples, 0 failures
3624 / 4037 LOC (89.77%) covered.
[TEST PROF INFO] Time spent in factories: 00:11.230 (43.2% of total time)

rspec: [ce]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/10274492741/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/1856819960/test_report
Finished in 19.85 seconds (files took 12.28 seconds to load)
1084 examples, 0 failures
3471 / 3900 LOC (89.0%) covered.
[TEST PROF INFO] Time spent in factories: 00:11.093 (43.36% of total time)

rubocop

615 files inspected, no offenses detected

… yet)

…put types, and update JSON schemas

…settings

…d enhance validation services

…prove code readability

…g, and update input types, add more specs

…e, enhance validation services and input types

…h, enhance validation services

db/migrate/20250525192143_implement_generics.rb

app/models/generic_combination_strategy.rb

app/models/generic_type.rb

app/models/namespace_role_ability.rb

app/models/node_parameter.rb

Taucher2003 · 2025-06-05T20:20:33Z

app/models/node_parameter.rb

+    return if values.count(true) == 1
+
+    errors.add(:base,
+               'Exactly one of literal_value, reference_value, or function_value must be present')


The string might make translation in the frontend difficult

I dont think thats a problem here. The frontend should send invalid data to us in the first place. This case is a very easy thing to validate in the frontend

…and runtime function definitions

…ove database level constraint for generic_keys (model only)

…values

…Strategy and status in Runtime

…plemented yet

…resence for type in GenericCombinationStrategy

Knerio self-assigned this May 28, 2025

Knerio force-pushed the 388-update-delete-create-flow branch from 3a70731 to 325ed59 Compare May 29, 2025 00:39

Knerio force-pushed the 420-flow-type-structure branch from 457223f to 1e5b28e Compare May 29, 2025 00:42

Knerio changed the base branch from 388-update-delete-create-flow to main May 29, 2025 18:39

Knerio force-pushed the 420-flow-type-structure branch from 354ef27 to 3c6b199 Compare May 29, 2025 18:42

Knerio mentioned this pull request May 30, 2025

Flow update mutation/service #490

Open

Knerio force-pushed the 420-flow-type-structure branch 2 times, most recently from de3ee11 to d002ae0 Compare May 30, 2025 13:01

Knerio changed the base branch from main to 491-type-graphql-ids May 30, 2025 20:58

Knerio force-pushed the 420-flow-type-structure branch 2 times, most recently from b71f4d7 to 8054e3e Compare May 30, 2025 22:31

Base automatically changed from 491-type-graphql-ids to main May 30, 2025 22:44

Knerio added 17 commits May 31, 2025 12:55

Update datatype model and runtime function (definition) models

7950e10

Adjust models and tests

cdf6cd5

Add Rails helper requirement to ping service spec

34b580b

Refactor foreign key constraints in generics implementation

ed6786f

Recompile structure.sql

d5f457d

Make migration reversible

2e8cc11

Fix rubocop vulnerabilities

51591c4

Refactor generic type and mapper associations (tucana 0.0.28)

770abe6

Recompile structure.sql

f69ad49

Fix rubocop vulnerabilities

87fc346

Recompile structure.sql

7528ffb

Adjust models and tests

13bad43

Update datatype model and runtime function (definition) models

67622d6

Adjust models and tests

025e136

Adjust models and tests

f134b7d

Create flow model and everything associated with it (no functionality…

1842be2

… yet)

Add flows association to NamespaceProject and update schema

df1ca1d

Knerio added 9 commits May 31, 2025 12:55

Add validation services for data types and node functions, enhance in…

e0d0ce1

…put types, and update JSON schemas

Enhance flow creation and validation process with new data types and …

2b6b2c9

…settings

Recompile structure.sql

d8f76e7

Refactor generic types and mappers, update data type associations, an…

bf83653

…d enhance validation services

Refactor validation services and input types, enhance logging, and im…

5047588

…prove code readability

Refactor flow creation and validation services, enhance error handlin…

dc7aa4d

…g, and update input types, add more specs

Add generic combination strategies and update generic mapper structur…

6a38727

…e, enhance validation services and input types

Add Zone.Identifier to .gitignore to prevent unwanted file tracking

360e366

Refactor generic mapper associations and update Gemfile for local pat…

a09d8b2

…h, enhance validation services

Knerio force-pushed the 420-flow-type-structure branch from 387a60a to a09d8b2 Compare May 31, 2025 10:55

Knerio requested a review from Taucher2003 May 31, 2025 12:46

Knerio mentioned this pull request May 28, 2025

Add Flow Validator #401

Open

Update tucana gem version to 0.0.30

fa0f944

Knerio marked this pull request as ready for review May 31, 2025 23:57

Knerio changed the title ~~WIP: flow type structure~~ flow type structure Jun 1, 2025

Taucher2003 reviewed Jun 5, 2025

View reviewed changes

Knerio added 9 commits June 6, 2025 10:11

remove parameter_id of function generic mapper

37731db

remove_reference also has specifies the foreign key now

49786ec

Add validation and constraints for generic_keys length in data types …

9b522ce

…and runtime function definitions

Remove runtime association from GenericType and related specs and rem…

12d5a59

…ove database level constraint for generic_keys (model only)

Fix rubocop vulnerabilities

f17379e

Update references in runtime and parameter definitions to allow null …

c3ddbc9

…values

Add presence and inclusion validations for type in GenericCombination…

10acdb0

…Strategy and status in Runtime

Change :base to :value

0d9487d

Change description of abilities and remove update_flows as its not im…

b836858

…plemented yet

Knerio force-pushed the 420-flow-type-structure branch from 5faca64 to b836858 Compare June 6, 2025 08:37

Knerio added 3 commits June 6, 2025 10:41

Update foreign key constraints to use cascade on delete and enforce p…

a6ff8ba

…resence for type in GenericCombinationStrategy

Regenerate docs

c37d4f1

Recompile structure.sql

1ec9b35

Knerio requested a review from Taucher2003 June 6, 2025 10:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

flow type structure #486

flow type structure #486

Uh oh!

Knerio commented May 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Taucher2003 Jun 5, 2025

Uh oh!

Knerio Jun 6, 2025

Uh oh!

Uh oh!

flow type structure #486

Are you sure you want to change the base?

flow type structure #486

Uh oh!

Conversation

Knerio commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GitLab Pipeline Action

General information

Job summaries

rspec: [ee]

rspec: [ce]

rubocop

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Taucher2003 Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

Knerio Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Knerio commented May 28, 2025 •

edited

Loading

github-actions bot commented May 28, 2025 •

edited

Loading