lint

Author: Thomas Stromberg

.yamllint

@@ -0,0 +1,16 @@
+---
+extends: default
+
+rules:
+  braces:
+    max-spaces-inside: 1
+  brackets:
+    max-spaces-inside: 1
+  comments: disable
+  comments-indentation: disable
+  document-start: disable
+  line-length:
+    level: warning
+    max: 160
+    allow-non-breakable-inline-mappings: true
+  truthy: disable

Makefile

@@ -70,7 +70,7 @@ LINTERS += yamllint-lint
 yamllint-lint: $(YAMLLINT_BIN)
 	PYTHONPATH=$(YAMLLINT_ROOT)/dist $(YAMLLINT_ROOT)/dist/bin/yamllint .
 
-BIOME_VERSION ?= 1.9.4
+BIOME_VERSION ?= 2.2.6
 BIOME_BIN := $(LINT_ROOT)/out/linters/biome-$(BIOME_VERSION)-$(LINT_ARCH)
 BIOME_CONFIG := $(LINT_ROOT)/biome.json
 
@@ -83,7 +83,7 @@ endif
 $(BIOME_BIN):
 	mkdir -p $(LINT_ROOT)/out/linters
 	rm -rf $(LINT_ROOT)/out/linters/biome-*
-	curl -sSfL -o $@ https://github.com/biomejs/biome/releases/download/cli%2Fv$(BIOME_VERSION)/biome-$(LINT_OS_LOWER)-$(BIOME_ARCH) \
+	curl -sSfL -o $@ https://github.com/biomejs/biome/releases/download/%40biomejs%2Fbiome%40$(BIOME_VERSION)/biome-$(LINT_OS_LOWER)-$(BIOME_ARCH) \
 		|| echo "Unable to fetch biome for $(LINT_OS_LOWER)/$(BIOME_ARCH), falling back to local install"
 	test -f $@ || printf "#!/usr/bin/env biome\n" > $@
 	chmod u+x $@

assets/app.js

@@ -5,7 +5,7 @@ import { Robots } from "./robots.js";
 import { Stats } from "./stats.js";
 import { User } from "./user.js";
 // Ready To Review - Modern ES6+ Application
-import { $, $$, clearChildren, el, hide, setHTML, show, showToast } from "./utils.js";
+import { $, clearChildren, el, hide, show, showToast } from "./utils.js";
 import { Workspace } from "./workspace.js";
 
 const App = (() => {
@@ -40,7 +40,7 @@ const App = (() => {
         isChangelog: true,
       };
     }
-    const changelogMatch = path.match(/^\/changelog\/([^\/]+)$/);
+    const changelogMatch = path.match(/^\/changelog\/([^/]+)$/);
     if (changelogMatch) {
       const [, username] = changelogMatch;
       return {
@@ -87,7 +87,7 @@ const App = (() => {
     }
 
     // Check for user dashboard pattern: /u/username
-    const userMatch = path.match(/^\/u\/([^\/]+)$/);
+    const userMatch = path.match(/^\/u\/([^/]+)$/);
     if (userMatch) {
       const [, username] = userMatch;
       return {
@@ -435,7 +435,7 @@ const App = (() => {
           const rateLimitReset = response.headers.get("X-RateLimit-Reset");
 
           if (rateLimitRemaining === "0") {
-            const resetTime = new Date(Number.parseInt(rateLimitReset) * 1000);
+            const resetTime = new Date(Number.parseInt(rateLimitReset, 10) * 1000);
             const now = new Date();
             const minutesUntilReset = Math.ceil((resetTime - now) / 60000);
 
@@ -464,7 +464,7 @@ const App = (() => {
               errorMessage = `GitHub error: ${firstError.message}`;
             }
           }
-        } catch (e) {
+        } catch (_e) {
           // Use default message
         }
 
@@ -488,14 +488,18 @@ const App = (() => {
 
   // Demo Mode
   const initializeDemoMode = () => {
+    // biome-ignore lint/correctness/noUndeclaredVariables: DEMO_DATA loaded as global from demo-data.js
     if (typeof DEMO_DATA === "undefined") {
       console.error("Demo data not loaded");
       return;
     }
 
     state.isDemoMode = true;
+    // biome-ignore lint/correctness/noUndeclaredVariables: DEMO_DATA loaded as global from demo-data.js
     state.currentUser = DEMO_DATA.user;
+    // biome-ignore lint/correctness/noUndeclaredVariables: DEMO_DATA loaded as global from demo-data.js
     state.viewingUser = DEMO_DATA.user;
+    // biome-ignore lint/correctness/noUndeclaredVariables: DEMO_DATA loaded as global from demo-data.js
     state.pullRequests = DEMO_DATA.pullRequests;
 
     const allPRs = [...state.pullRequests.incoming, ...state.pullRequests.outgoing];
@@ -570,6 +574,7 @@ const App = (() => {
 
     const urlContext = parseURL();
     if (!urlContext || !urlContext.username) {
+      // biome-ignore lint/correctness/noUndeclaredVariables: DEMO_DATA loaded as global from demo-data.js
       window.location.href = `/u/${DEMO_DATA.user.login}?demo=true`;
       return;
     }
@@ -625,7 +630,7 @@ const App = (() => {
       path === "/" ||
       path.startsWith("/u/") ||
       path === "/robots" ||
-      path.match(/^\/robots\/gh\/[^\/]+$/)
+      path.match(/^\/robots\/gh\/[^/]+$/)
     ) {
       show(searchInput);
     } else {
@@ -714,7 +719,7 @@ const App = (() => {
     }
     // Handle notifications page routing
     const path = window.location.pathname;
-    if (path === "/notifications" || path.match(/^\/notifications\/gh\/[^\/]+$/)) {
+    if (path === "/notifications" || path.match(/^\/notifications\/gh\/[^/]+$/)) {
       updateSearchInputVisibility();
       const token = Auth.getStoredToken();
       if (token) {
@@ -731,7 +736,7 @@ const App = (() => {
     }
 
     // Handle robots page routing
-    if (path === "/robots" || path.match(/^\/robots\/gh\/[^\/]+$/)) {
+    if (path === "/robots" || path.match(/^\/robots\/gh\/[^/]+$/)) {
       updateSearchInputVisibility();
       const token = Auth.getStoredToken();
       if (!token) {
@@ -969,7 +974,7 @@ const App = (() => {
     Robots.copyYAML();
     try {
       showToast("Configuration copied to clipboard!", "success");
-    } catch (error) {
+    } catch (_error) {
       showToast("Failed to copy to clipboard", "error");
     }
   };

assets/auth.js

@@ -31,7 +31,7 @@ export const Auth = (() => {
   }
 
   function getCookie(name) {
-    const nameEQ = name + "=";
+    const nameEQ = `${name}=`;
     const ca = document.cookie.split(";");
     for (let i = 0; i < ca.length; i++) {
       let c = ca[i];
@@ -79,7 +79,7 @@ export const Auth = (() => {
     console.log("[Auth.initiateOAuthLogin] Current URL:", window.location.href);
     console.log(
       "[Auth.initiateOAuthLogin] Redirecting to:",
-      window.location.origin + "/oauth/login"
+      `${window.location.origin}/oauth/login`
     );
 
     // Simply redirect to the backend OAuth endpoint
@@ -198,7 +198,7 @@ export const Auth = (() => {
           errorDiv.style.display = "block";
         }
       }
-    } catch (error) {
+    } catch (_error) {
       if (errorDiv) {
         errorDiv.textContent = "Error validating token. Please try again.";
         errorDiv.style.display = "block";
@@ -274,7 +274,7 @@ export const Auth = (() => {
 
     const token = getStoredToken();
     if (token) {
-      headers["Authorization"] = `token ${token}`;
+      headers.Authorization = `token ${token}`;
     }
 
     let lastError;
@@ -302,14 +302,14 @@ export const Auth = (() => {
               const responseClone = response.clone();
               const responseText = await responseClone.text();
               console.warn("Response body:", responseText);
-            } catch (e) {
+            } catch (_e) {
               console.warn("Could not read response body due to CORS restrictions");
             }
           }
 
           // Retry on all 500+ server errors
           if (response.status >= 500 && attempt < retries) {
-            const delay = Math.min(250 * Math.pow(2, attempt), 10000); // Exponential backoff starting at 250ms, max 10s
+            const delay = Math.min(250 * 2 ** attempt, 10000); // Exponential backoff starting at 250ms, max 10s
             console.warn(
               `[githubAPI] Retry ${attempt + 1}/${retries} for ${CONFIG.API_BASE}${endpoint} - Status: ${response.status}, Delay: ${delay}ms`
             );
@@ -325,7 +325,7 @@ export const Auth = (() => {
 
         // If it's a network error and we have retries left, try again
         if (attempt < retries) {
-          const delay = Math.min(250 * Math.pow(2, attempt), 10000);
+          const delay = Math.min(250 * 2 ** attempt, 10000);
           console.warn(
             `[githubAPI] Network error retry ${attempt + 1}/${retries} for ${CONFIG.API_BASE}${endpoint} - Error: ${error.message}, Delay: ${delay}ms`
           );
@@ -385,7 +385,7 @@ export const Auth = (() => {
 
           // Retry on all 500+ server errors
           if (response.status >= 500 && attempt < retries) {
-            const delay = Math.min(250 * Math.pow(2, attempt), 10000); // Exponential backoff starting at 250ms, max 10s
+            const delay = Math.min(250 * 2 ** attempt, 10000); // Exponential backoff starting at 250ms, max 10s
 
             // Log all available response information
             console.warn(
@@ -397,7 +397,7 @@ export const Auth = (() => {
             try {
               const responseText = await response.text();
               console.warn("Response body:", responseText);
-            } catch (e) {
+            } catch (_e) {
               console.warn("Could not read response body due to CORS restrictions");
             }
 
@@ -410,15 +410,15 @@ export const Auth = (() => {
           console.error("Request details:", {
             query,
             variables,
-            authHeader: authHeader.substring(0, 20) + "...",
+            authHeader: `${authHeader.substring(0, 20)}...`,
           });
           throw new Error(`GraphQL request failed: ${response.status} ${response.statusText}`);
         }
 
         const data = await response.json();
         if (data.errors) {
           console.error("GraphQL errors:", data.errors);
-          throw new Error("GraphQL query failed: " + data.errors[0]?.message);
+          throw new Error(`GraphQL query failed: ${data.errors[0]?.message}`);
         }
 
         return data.data;
@@ -427,7 +427,7 @@ export const Auth = (() => {
 
         // If it's a network error and we have retries left, try again
         if (error.name === "TypeError" && error.message.includes("fetch") && attempt < retries) {
-          const delay = Math.min(250 * Math.pow(2, attempt), 10000);
+          const delay = Math.min(250 * 2 ** attempt, 10000);
           console.warn(
             `[githubGraphQL] Network error retry ${attempt + 1}/${retries} for ${CONFIG.API_BASE}/graphql - Error: ${error.message}, Delay: ${delay}ms`
           );

assets/changelog.js

@@ -216,7 +216,7 @@ export const Changelog = (() => {
 
         // Wait before retrying (exponential backoff)
         if (attempt < maxRetries) {
-          const delay = Math.min(1000 * Math.pow(2, attempt - 1), 5000);
+          const delay = Math.min(1000 * 2 ** (attempt - 1), 5000);
           await new Promise((resolve) => setTimeout(resolve, delay));
         }
       }

assets/demo-data.js

@@ -3,6 +3,7 @@
  * Mock data representing a busy software engineer working on Go, Terraform, and React
  */
 
+// biome-ignore lint/correctness/noUnusedVariables: Used as global variable in app.js
 const DEMO_DATA = {
   user: {
     login: "demo",

assets/leaderboard.js

@@ -1,6 +1,6 @@
 import { Stats } from "./stats.js";
 // Leaderboard Module - Shows PR merge activity by contributor
-import { $, $$, escapeHtml, hide, show, showToast } from "./utils.js";
+import { $, $$, hide, show, showToast } from "./utils.js";
 
 export const Leaderboard = (() => {
   const TEN_DAYS_IN_MS = 10 * 24 * 60 * 60 * 1000;
@@ -56,7 +56,9 @@ export const Leaderboard = (() => {
     loadUserOrganizations
   ) => {
     // Hide other content
-    $$('[id$="Content"], #prSections').forEach((el) => el?.setAttribute("hidden", ""));
+    $$('[id$="Content"], #prSections').forEach((el) => {
+      el?.setAttribute("hidden", "");
+    });
 
     // Check for authentication first
     if (!state.accessToken) {
@@ -87,7 +89,7 @@ export const Leaderboard = (() => {
       }
     }
 
-    updateUserDisplay(state, () => {});
+    updateUserDisplay(state, () => undefined);
     setupHamburgerMenu();
 
     // Update search input placeholder
@@ -150,7 +152,7 @@ export const Leaderboard = (() => {
         mergedPRs = cached.data;
         console.log("Cached leaderboard data:", {
           totalPRs: mergedPRs.length,
-          cacheAge: Math.round(cached.age / 60000) + " minutes",
+          cacheAge: `${Math.round(cached.age / 60000)} minutes`,
           dateRange: {
             from: new Date(Date.now() - TEN_DAYS_IN_MS).toISOString().split("T")[0],
             to: new Date().toISOString().split("T")[0],
@@ -280,7 +282,7 @@ export const Leaderboard = (() => {
               <div class="chart-content">
                 ${topContributors
                   .slice(0, 5)
-                  .map((author, index) => {
+                  .map((author, _index) => {
                     const percentage = (author.count / maxContributorCount) * 100;
                     return `
                     <div class="chart-item">
@@ -305,7 +307,7 @@ export const Leaderboard = (() => {
               <div class="chart-content">
                 ${topRepos
                   .slice(0, 5)
-                  .map((repo, index) => {
+                  .map((repo, _index) => {
                     const percentage = (repo.count / maxRepoCount) * 100;
                     const shortName = repo.name.split("/")[1] || repo.name;
                     return `