Skip to content

Conversation

rohitpaulk
Copy link
Member

Update the development workflow documentation to clarify the linting
and testing process. Advise running npm run lint after making
changes and only running tests selectively using npx run ember test
with module names, instead of using slow commands like npm test or
npm run test. Provide guidance on finding the module name in test
files or asking for help when unsure.

Update the development workflow documentation to clarify the linting
and testing process. Advise running `npm run lint` after making
changes and only running tests selectively using `npx run ember test`
with module names, instead of using slow commands like `npm test` or
`npm run test`. Provide guidance on finding the module name in test
files or asking for help when unsure.
Copy link

Test Results

  1 files  ±0    1 suites  ±0   8m 55s ⏱️ -34s
665 tests +5  617 ✅ +6  48 💤 ±0  0 ❌ ±0 
665 runs  +5  617 ✅ +7  48 💤 ±0  0 ❌  - 1 

Results for commit 92f18b7. ± Comparison against base commit 83b0d52.

This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both.
Chrome ‑ error
Chrome 140.0 ‑ Acceptance | course-admin | view-submissions: it should be able to filter by stage(s) through a dropdown menu
Chrome 140.0 ‑ Acceptance | course-admin | view-submissions: it should be accessible if user is course author and authored current course
Chrome 140.0 ‑ Acceptance | course-admin | view-submissions: it should handle null value for tree SHA
Chrome 140.0 ‑ Acceptance | course-admin | view-submissions: it should have the commit SHA in the header
Chrome 140.0 ‑ Acceptance | course-admin | view-submissions: it should have the tree SHA in the header
Chrome 140.0 ‑ Acceptance | course-admin | view-submissions: it should not be accessible if user is course author and did not author current course

Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@rohitpaulk rohitpaulk merged commit c7edde5 into main Sep 26, 2025
9 checks passed
@rohitpaulk rohitpaulk deleted the pk-branch-5 branch September 26, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant