Skip to content

Conversation

sebjulliand
Copy link
Member

@sebjulliand sebjulliand commented Aug 25, 2025

Changes

The cause of a connection failure was never reported after it happened. This PR fixes this and add the error message in the error notification.

image

It also adds error details (error JSON representation + stack trace) into the output to help diagnose connection issues.
image

This should help with #2856 and #2840 .

A new SSH debug output option has been added in the Login settings:
image

When turned on, it will append SSH debug traces to the Code for i output.
image

How to test this PR

  1. Connect to a system with the wrong address or credentials. Or shut down the SSH server on the LPAR
  2. Check out the error notification to see the cause of the issue
  3. Check out the Code for IBM i output for error details

Checklist

  • have tested my change

Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
@sebjulliand sebjulliand requested a review from a team August 25, 2025 10:02
@sebjulliand sebjulliand self-assigned this Aug 25, 2025
@sebjulliand sebjulliand added the enhancement New feature or request label Aug 25, 2025
@sebjulliand sebjulliand temporarily deployed to testing_environment August 25, 2025 10:02 — with GitHub Actions Inactive
Copy link
Contributor

github-actions bot commented Aug 25, 2025

👋 A new build is available for this PR based on dff7073.

@sebjulliand
Copy link
Member Author

Added a new SSH Debug output option in the Login settings:
image

Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
@sebjulliand sebjulliand temporarily deployed to testing_environment August 26, 2025 08:19 — with GitHub Actions Inactive
Copy link
Member

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried two different scenarios and it works great! This is a nice touch. At first I was confused why it's not a global setting instead of a per-connection, but it does make sense now.

{"errno":-3008,"code":"ENOTFOUND","syscall":"getaddrinfo","hostname":"-xxxx-","vslsStack":[{},{}],"level":"client-socket"}

Error: getaddrinfo ENOTFOUND -xxxx-
    at GetAddrInfoReqWrap.onlookupall [as oncomplete] (node:dns:122:26)
    at GetAddrInfoReqWrap.callbackTrampoline (node:internal/async_hooks:130:17)
[SSH debug] Outbound: Sending CHANNEL_OPEN (r:62, session)
[SSH debug] Inbound: CHANNEL_OPEN_CONFIRMATION (r:62, s:1)
[SSH debug] Outbound: Sending CHANNEL_REQUEST (r:1, exec: cd /home/SNDBX87 ; ls $HOME/.vscode/mapepire-server-2.3.3.jar)

These logs will be very useful in the future, I am sure!

Merge when you're ready 💯

@sebjulliand
Copy link
Member Author

Thanks @worksofliam !

These logs will be very useful in the future, I am sure!

It proved to be useful already 😅: #2840 (comment)

@sebjulliand sebjulliand merged commit d7f9f6f into master Aug 26, 2025
5 checks passed
@sebjulliand sebjulliand deleted the connectionErrorReport branch August 26, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants