Update about page content #122
Conversation
There was a problem hiding this comment.
Thanks!
There's a lot of blank lines, which I think you should get rid of most, if not all of them. I think a blank line is ok if the code really looks too jumbled without it, but there really shouldn't be 2 or 3 blank lines together, and there shouldn't be blank lines inside tags like <p>
Also there are merge conflicts because your branch is out of date. You'll need to rebase with git pull -r upsteam main (-r causes it to rebase rather than create a merge commit). When you rebase you'll need to resolve merge conflicts manually.
I notice the page was renamed from AboutPage to About, but otherwise the page is unchanged I think?
|
I've just discussed with Michael today about the changes. For the I've got a PR for that (PR #126) so we got that covered. |
|
Oh, one more thing to note from Michael, we could add the following for the topline in the About section: """ It’s called "Tenant First Aid" because it’s like emergency help for renters facing eviction—quick, clear, and focused on what to do right now. Just like medical first aid helps stabilize someone before they can see a doctor, Tenant First Aid gives Oregon tenants the essential legal info they need to understand an eviction notice, respond on time, and avoid mistakes that could cost them their home. |
iris-mq
force-pushed
the
Update-about-page-content
branch
from
2f58556 to
bd43063
Compare
|
I've addressed the requested changes. Let me know if anything else needs updating! |
| const navigate = useNavigate(); | ||
|
|
||
| return ( | ||
| <div className="flex items-center h-dvh pt-16 sm:pt-0"> |
There was a problem hiding this comment.
I've noticed the main div element used for styling the mobile version of the component has been removed and the classes for the first children been reverted to the old styling.
Recent changes like this element are in place to make content fill out more of the space.
There was a problem hiding this comment.
Hmm yeah I'm trying to rebase to resolve this issue. Got my brain twisted, but I'll come back to it again tomorrow.
There was a problem hiding this comment.
All good, think this and the merge conflict should be the last things. I'm good with all the other changes. 👍
|
Replaced this PR with #156. Made a new branch, copied over the changes, and made a couple style adjustments based on the extra length of the text. Please review that PR instead of this one, this one can be closed. |
Update text of about page to include Michael Zhang's 6/16/25 edits.