-
Notifications
You must be signed in to change notification settings - Fork 11
Alternative Python Type-checkers #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imo lets just stick with one and enforce that.
Is there one type-checker be configured to cover all three? If not all three, we could select either the strictest one or the one most relevant to other PRs? |
We could stick with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My 2 cents would be to just introduce mypy without enforcement then
…nd ignores in session.py
2c5998c
to
203f6b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve this, I'll fix any type issues in a new PR, then we could add it as a PR action. I might also add ruff check
as a precommit action.
Makefile
&README.md
This does not enable the other type-checkers in PR Checks. The 3 type-checkers flag different issues.
mypy
is the grand-daddy of Python type-checking and is probably the most complete.pyrefly
is a new implementation, similar in vintage toty
but they each flag (or not) different issues.This may be useful for folks who are adding type annotations (e.g. #121)