Skip to content

Commit fe56d83

Browse files
committed
Fix layout bugs and improve accessibility
1 parent 06a9717 commit fe56d83

File tree

3 files changed

+22
-18
lines changed

3 files changed

+22
-18
lines changed

_layouts/2018.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@
1717
<body>
1818
<header id=main-header>
1919
<section>
20-
<img src="{{ site.baseurl }}/logos/snowflake-with-codefreeze.svg" alt="Snowflake" class="snowflake" />
20+
<h1 aria-label="{{page.title}}">
21+
<img src="{{ site.baseurl }}/logos/snowflake-with-codefreeze.svg" alt="Codefreeze logo" class="snowflake" />
22+
</h1>
2123
<p>
2224
<time>{{page.when}}</time>
2325
<span class="location">{{page.where}}</span>

index.md

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ where_link: https://www.kiilopaa.fi/en/
88
description: Codefreeze is an unconference with very little structure. Actually, it’s not a conference at all. Codefreeze is a time and place for software craftspeople to meet.
99
---
1010

11-
# {{page.title}}
12-
1311
## {{page.tagline}}
1412

1513
Codefreeze is an unconference with very little structure. Actually, it’s not a conference at all. Codefreeze is a *time* and *place* for software craftspeople to meet. We would like to have likeminded people to gather in one place and have long conversations about our craft over a drink. And to practice our coding skills.
@@ -237,7 +235,7 @@ For more information about the safaris, including prices, see the brochure here
237235
<img src="{{ site.baseurl }}/images/user-add.jpg" alt="{{ participant.name }}" />
238236
</div>
239237
</a>
240-
<h3>You?</h3>
238+
<div class="participant-name">You?</div>
241239
</li>
242240

243241
<!-- {% assign image_host = site.url | append:site.baseurl %} -->
@@ -250,23 +248,23 @@ For more information about the safaris, including prices, see the brochure here
250248
<li>
251249
{% if participant.link != null %}<a href="{{ participant.link }}" rel="noopener noreferrer">{% endif %}
252250
<div class="photo">
253-
<img src="{{ image_url }}" alt="{{ participant.name }}" />
251+
<img src="{{ image_url }}" alt="Picture of {{ participant.name }}" />
254252
</div>
255253
{% if participant.link != null %}</a>{% endif %}
256-
<h3>{{ participant.name }}</h3>
257-
<nav>
258-
{% if participant.link != null %}<a href="{{ participant.link }}" rel="noopener noreferrer">
254+
<div class="participant-name">{{ participant.name }}</div>
255+
<div class="participant-links">
256+
{% if participant.link != null %}<a href="{{ participant.link }}" rel="noopener noreferrer" aria-label="Homepage of {{ participant.name }}">
259257
<i class="fas fa-home"></i>
260258
</a>{% endif %}
261259
{% if participant.twitter != null %}
262-
<a href="https://twitter.com/{{ participant.twitter }}" rel="noopener noreferrer">
260+
<a href="https://twitter.com/{{ participant.twitter }}" rel="noopener noreferrer" aria-label="Twitter profile of {{ participant.name }}">
263261
<i class="fab fa-twitter"></i></a>
264262
{% endif %}
265263
{% if participant.linkedin != null %}
266-
<a href="{{ participant.linkedin }}" rel="noopener noreferrer">
264+
<a href="{{ participant.linkedin }}" rel="noopener noreferrer" aria-label="LinkedIn profile of {{ participant.name }}">
267265
<i class="fab fa-linkedin"></i></a>
268266
{% endif %}
269-
</nav>
267+
</div>
270268
{% if participant.content != null %}<div class="description">{{ participant.content }}</div>{% endif %}
271269
</li>
272270
{% endfor %}

styles/2018.scss

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -84,12 +84,15 @@ body > header {
8484
}
8585
}
8686

87-
body > main {
87+
#main-header {
88+
h1 {
89+
margin: 0
90+
}
91+
}
92+
93+
main {
8894
padding: 0;
8995
margin: 0;
90-
> h1 {
91-
display: none;
92-
}
9396
hr {
9497
border: 0;
9598
border-bottom: 5px solid $blue;
@@ -191,7 +194,8 @@ section.tweets {
191194
margin: 2rem 0;
192195
padding: 2rem;
193196
@media (min-width: $desktop-width) {
194-
padding: 4rem;
197+
padding-left: 4rem;
198+
padding-right: 4rem;
195199
}
196200

197201
a {
@@ -248,7 +252,7 @@ section.tweets {
248252
}
249253
}
250254

251-
h3 {
255+
.participant-name {
252256
font-size: 18px;
253257
font-weight: $thin-weight;
254258
margin: 0 0 0 0.5rem;
@@ -261,7 +265,7 @@ section.tweets {
261265
display: none;
262266
}
263267

264-
nav a {
268+
.participant-links a {
265269
text-decoration: none;
266270
font-size: 150%;
267271
&+a {

0 commit comments

Comments
 (0)