Skip to content

Commit 704c83b

Browse files
cr 11721 (#428)
* wip * bump * bump * resolve comment
1 parent 163a0fd commit 704c83b

File tree

4 files changed

+36
-3
lines changed

4 files changed

+36
-3
lines changed

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0.43.6
1+
0.43.7

pkg/codefresh/codefresh.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,13 @@ func (c *codefresh) AppProxy(ctx context.Context, runtime string, insecure bool)
135135
return nil, fmt.Errorf("failed to create app-proxy client for runtime %s: %w", runtime, err)
136136
}
137137

138-
if rt.IngressHost == nil || *rt.IngressHost == "" {
138+
var host string
139+
140+
if rt.InternalIngressHost != nil && *rt.InternalIngressHost != "" {
141+
host = *rt.InternalIngressHost
142+
} else if rt.IngressHost != nil && *rt.IngressHost != "" {
143+
host = *rt.IngressHost
144+
} else {
139145
return nil, fmt.Errorf("failed to create app-proxy client for runtime %s: runtime does not have ingressHost configured", runtime)
140146
}
141147

@@ -148,7 +154,7 @@ func (c *codefresh) AppProxy(ctx context.Context, runtime string, insecure bool)
148154
}
149155

150156
return newClient(&ClientOptions{
151-
Host: *rt.IngressHost,
157+
Host: host,
152158
Auth: AuthOptions{Token: c.token},
153159
Client: httpClient,
154160
graphqlPath: "/app-proxy/api/graphql",

pkg/codefresh/model/app-proxy/models_gen.go

Lines changed: 23 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/codefresh/model/models_gen.go

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)