Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the main type errors found by running the Ty typechecker on the codegen repository.
Changes Made
1. RestAPI Identity Implementation
identify()
method toRestAPI
class insrc/codegen/cli/api/client.py
AuthContext
andIdentity
for the identity API2. Path Handling Fixes in init/main.py
path_obj
instead of reassigningpath
)sys.exit()
3. Subprocess Return Type Fix
subprocess_with_stopwatch
function to ensure string output by settingtext=True
CompletedProcess[bytes]
vsCompletedProcess[str]
mismatch4. Jupyter Notebook Session Fix
CodegenSession
initialization withrepo_path
parameterType Errors Resolved
RestAPI
missingidentify()
methodinit/main.py
(Path vs str type conflicts)get_git_root_path
functionTesting
All fixes maintain backward compatibility and existing functionality. The changes primarily add type safety without changing runtime behavior.
Note: Test files that intentionally call functions incorrectly (to test error handling) will still show Ty warnings, which is expected behavior.
💻 View my work • About Codegen