fix: W3C html semantic errors #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-maillot
force-pushed
the
fix/html-semantic-errors
branch
from
b2e3da2 to
be282fb
Compare
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correction d'erreurs sémantiques remonté par l'outil d'analyse https://validator.w3.org/ sur notre site :
https://validator.w3.org/nu/?doc=https%3A%2F%2Fcode-du-travail-numerique-preprod.ovh.fabrique.social.gouv.fr%2Fmentions-legales
Il y a 3 erreurs corrigées :
Le role dialog sur une dialog n'est pas requis car implicite avec la balise dialog. Pour moi, ce devrait être un warning mais ça remonte en erreur.
Ici on utilise deux fois le même id. Je pense que c'est une erreur de copier/coller car le second id est sur un bouton pour fermer la recherche. Je l'ai donc renommé pour que ça corresponde à son role.
On ajoute aria-describedby sur l'input même si l'on a pas de message descriptif.