Skip to content

Commit 601f38f

Browse files
committed
refactor: extract methods
1 parent 851885d commit 601f38f

File tree

1 file changed

+24
-12
lines changed

1 file changed

+24
-12
lines changed

src/Authorization/Traits/Authorizable.php

Lines changed: 24 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,7 @@ public function addGroup(string ...$groups): self
2121
{
2222
$this->populateGroups();
2323

24-
$configGroups = function_exists('setting')
25-
? array_keys(setting('AuthGroups.groups'))
26-
: array_keys(config('AuthGroups')->groups);
24+
$configGroups = $this->getConfigGroups();
2725

2826
$groupCount = count($this->groupCache);
2927

@@ -86,9 +84,7 @@ public function syncGroups(array $groups): self
8684
{
8785
$this->populateGroups();
8886

89-
$configGroups = function_exists('setting')
90-
? array_keys(setting('AuthGroups.groups'))
91-
: array_keys(config('AuthGroups')->groups);
87+
$configGroups = $this->getConfigGroups();
9288

9389
foreach ($groups as $group) {
9490
if (! in_array($group, $configGroups, true)) {
@@ -134,9 +130,7 @@ public function addPermission(string ...$permissions): self
134130
{
135131
$this->populatePermissions();
136132

137-
$configPermissions = function_exists('setting')
138-
? array_keys(setting('AuthGroups.permissions'))
139-
: array_keys(config('AuthGroups')->permissions);
133+
$configPermissions = $this->getConfigPermissions();
140134

141135
$permissionCount = count($this->permissionsCache);
142136

@@ -199,9 +193,7 @@ public function syncPermissions(array $permissions): self
199193
{
200194
$this->populatePermissions();
201195

202-
$configPermissions = function_exists('setting')
203-
? array_keys(setting('AuthGroups.permissions'))
204-
: array_keys(config('AuthGroups')->permissions);
196+
$configPermissions = $this->getConfigPermissions();
205197

206198
foreach ($permissions as $permission) {
207199
if (! in_array($permission, $configPermissions, true)) {
@@ -382,4 +374,24 @@ private function saveGroupsOrPermissions(string $type, $model, array $cache): vo
382374
$model->insertBatch($inserts);
383375
}
384376
}
377+
378+
/**
379+
* @return string[]
380+
*/
381+
private function getConfigGroups(): array
382+
{
383+
return function_exists('setting')
384+
? array_keys(setting('AuthGroups.groups'))
385+
: array_keys(config('AuthGroups')->groups);
386+
}
387+
388+
/**
389+
* @return string[]
390+
*/
391+
private function getConfigPermissions(): array
392+
{
393+
return function_exists('setting')
394+
? array_keys(setting('AuthGroups.permissions'))
395+
: array_keys(config('AuthGroups')->permissions);
396+
}
385397
}

0 commit comments

Comments
 (0)