Skip to content

[이영찬] sprint1 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
Binary file not shown.
Binary file added 1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions 10-Sprint-Mission
Submodule 10-Sprint-Mission added at 4dc5dd
Binary file added 2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added 3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added footimage.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added headimage.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ic_facebook.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ic_instagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ic_twitter.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ic_youtube.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
133 changes: 133 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,133 @@
<!DOCTYPE html>
<html lang="en">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

현재 사용자가 보는 문서의 언어는 ko로 지정하시는게 적절할 것 같습니다!

<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" href="style.css">
<title>판다마켓</title>
</head>
<body>
<header>
<div class="header">
<div class="title">
<img src="panda.png">
<h1 class="name">
<a href="https://10-sprintmission1.netlify.app/">판다마켓</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

배포 도메인을 직접 기재하시면 개발 단계에서는 다소 확인이 어려울 수 있습니다~!
현 시점에서는 상대 경로로 넣어주시는게 좋을 것 같네요. :)

</h1>
Comment on lines +14 to +16
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h1, a 태그 적절하게 사용하셨네요. 잘 하셨습니다. 👍

</div>
<div class="login">
<a href="https://10-sprintmission1.netlify.app/login">로그인</a>
</div>
</div>
</header>
<main>
<div class="part1">
<div class="mention">
<h1>
일상의 모든 물건을<br>
거래해 보세요
</h1>
<div class="look">
<a href="https://10-sprintmission1.netlify.app/items">구경하러 가기</a>
</div>
</div>
<img src="headimage.png" class="headimage">
</div>
<div class="part2-1">
<div class="box1">
<img class="img" src="1.png">
<div class="explain">
<div class="explain_box1">
<div class="explain_title">
Hot item
</div>
<h1>
인기 상품을<br>
확인해 보세요
</h1>
<h2>
가장 HOT한 중고거래 물품을<br>
판다 마켓에서 확인해 보세요
</h2>
Comment on lines +44 to +51
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heading 태그는 해당 영역의 제목을 나타냅니다. 제목 이외의 요소는 상황에 맞게 <p/>, <span/>, <div/> 등을 사용하셔서 나타내시면 될 것 같습니다.

</div>
</div>
</div>
</div>
<div class="part2-2">
<div class="box2">
<div class="explain">
<div class="explain_box2">
<div class="explain_title">
Search
</div>
<h1>
구매를 원하는<br>
상품을 검색하세요
</h1>
<h2>
구매하고 싶은 물품은 검색해서<br>
쉽게 찾아보세요
</h2>
</div>
</div>
<img class="img" src="2.png">
Copy link
Collaborator

@hoody-jellybean hoody-jellybean Aug 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아마 피그마에서 export한 이미지를 그대로 사용하셔서 2.png와 같은 명칭을 사용 중이시겠지만,
네임 스페이스 중복을 막으면서도 어떤 요소인지 명확하게 드러나도록 수정하셔서 사용하시는게 좋을 것 같습니다. :)

</div>
</div>
<div class="part2-1">
<div class="box1">
<img class="img" src="3.png">
<div class="explain">
<div class="explain_box1">
<div class="explain_title">
Register
</div>
<h1>
판매를 원하는<br>
상품을 등록하세요
</h1>
<h2>
어떤 물건이든 판매하고 싶은 상품을<br>
쉽게 등록하세요
</h2>
</div>
</div>
</div>
</div>
<div class="empty_space"></div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빈 공간을 별도로 생성하신 이유가 있을까요?

<div class="part1">
<div class="mention">
<h1>
믿을 수 있는<br>
판다마켓 중고 거래
</h1>
</div>
<img src="footimage.png" class="footimage">
</div>
</main>
<footer>
<div class="part3">
<div class="information">
<h3>
©codeit - 2024
</h3>
<div>
<h3>
<a href="/privacy">Privacy Policy</a>
</h3>
<h3>
<a href="/faq">FAQ</a>
</h3>
</div>
<div class="icons">
<a href="https://www.facebook.com/" target="_blank"><img src="ic_facebook.png" class="icon"></a>
<a href="https://www.twitter.com/" target="_blank"><img src="ic_twitter.png" class="icon"></a>
<a href="https://www.youtube.com/" target="_blank"><img src="ic_youtube.png" class="icon"></a>
<a href="https://www.instagram.com/" target="_blank"><img src="ic_instagram.png" class="icon"></a>
Comment on lines +122 to +125
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미지만 있는 요소는 alt 속성으로 이미지가 불러오지 않았거나, 화면을 볼 수 없는 스크린 리더 사용자들이 읽을 수 있도록 텍스트 콘텐츠를 함께 제공해주시면 더 좋습니다. :)

</div>
</h3>
</div>
</div>
</footer>

</body>
</html>
Binary file added panda.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
222 changes: 222 additions & 0 deletions style.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,222 @@
* {
box-sizing: border-box;
}

a {
text-decoration: none;
cursor: pointer;
color: inherit;
}

body {
width: 1920px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고정 너비로 1920px을 넣으시면 반응형 대응이 안됩니다! 참고해 주세요.

padding: 0px;
margin: 0px;
}

header {
width: 1920px;
height: 70px;
position: relative;
}

.header {
width: 1120px;
height: 51px;
display: flex;
justify-content: space-between;
align-items: center;
position: absolute;
margin: 9.5px 400px;
}

h1 {
font-weight: 700;
font-size: 40px;
line-height: 56px;
}

h2 {
font-weight: 500;
font-size: 24px;
color: #374151;
}

h3 {
font-size: 16px;
font-weight: 400;
color: #e5e7e8;
}
Comment on lines +33 to +49
Copy link
Collaborator

@hoody-jellybean hoody-jellybean Aug 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style.css를 홈 랜딩 화면에서만 사용하시면 태그 단위로 지정하셔도 되지만,
추후에 공통으로 사용하시는 경우 다른 화면에도 영향을 줄 수 있습니다.

가급적이면 서비스 전반적으로 해당 요소의 공통 스타일인 경우가 아니면 태그 단위로 스타일 적용하는 방식은 지양해 주세요. :)
(ex. 크로스 브라우징을 위해 요소의 스타일을 동일하게 초기화하는 CSS)


.name {
font-weight: 700;
font-size: 25.63px;
margin-left: 10px;
color: #3682ff;
}

.title {
display: flex;
align-items: center;
}

.login {
font-weight: 600;
font-size: 16px;
color: #f3f4f6;
width: 128px;
height: 48px;
padding: 12px 23px 12px 23px;
border: solid;
border-radius: 8px;
background-color: #3692ff;
text-align: center;
}

.part1 {
background-color: #cfe5ff;
width: 100%;
height: 540px;
position: relative;
display: flex;
justify-content: center;
align-items: flex-end;
}

.part2-1 {
width: 1920px;
height: 720px;
position: relative;
}

.part2-2 {
width: 1920px;
height: 720px;
position: relative;
}

.part3 {
background-color: #111827;
width: 1920px;
height: 160px;
position: relative;
display: flex;
}

.empty_space {
width: 1920px;
height: 138px;
background-color: #fcfcfc;
}
.part3 .information > div {
width: 159px;
display: flex;
justify-content: space-between;
}
.headimage, .footimage {
width: 746px;
height: 340px;
}
Comment on lines +111 to +119
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다양한 CSS Selector 사용해보시는 것 너무 좋네요. 👍


.mention{
width: 357px;
height: 26opx;
padding: 0px 0px 60px 0px;
margin: 40px 0px;
color: #374151
}

.look {
width: 357px;
height: 56px;
font-size: 20px;
font-weight: 600;
border-radius: 40px;
background-color: #3682ff;
color: white;
padding: 16px 120px; /*124px로 하면 마지막 글자가 자꾸 내려가요 */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 요소의 박스 너비가 357px로 고정되어 있고, 좌우 여백이 124px이어서 그렇습니다.
박스 내에 콘텐츠가 그려질 수 있는 영역은 357 - 124 * 2 밖에 안되서 컨텐츠 너비를 초과한 요소에 줄바꿈이 적용되시는 것 같네요.

}

.box1 {
width: 955px;
height: 444px;
background-color: #fcfcfc;
position: absolute;
top: 138px;
left: 360px;
Comment on lines +144 to +146
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

position: absolute를 사용하신 이유가 있을까요?

display: flex;
}

.box2 {
width: 955px;
height: 444px;
background-color: #fcfcfc;
position: absolute;
top: 138px;
right: 360px;
display: flex;
}

.img {
width: 588px;
height: 444px
}

.explain {
width: 367px;
height: 238px;
}

.explain_box1 {
margin-top:103px;
margin-bottom: 103px;
margin-left: 40px;
}

.explain_box2 {
margin-top:103px;
margin-bottom: 103px;
margin-right: 40px;
}

.part2-2 .explain_box2 {
text-align: right;
}

.explain_title {
color:#3682ff;
font-weight: 700;
font-size: 18px;
line-height: 26px;
}

.information {
width: 1120px;
height: 20px;
display: flex;
justify-content: space-between;
align-items: center;
position: absolute;
top: 20px;
left: 400px;
}

.icon {
width: 20px;
height: 20px;
}

.icons {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아이템을 가지는 리스트 요소에 고정 너비를 주시면, 아이템이 추가 또는 제거되었을 때 너비 스타일까지 같이 조정해주셔야 합니다.
이 경우에는 flex layout은 유지하되, 아이템 간에 마진을 주어서 간격 처리를 하시는게 나을 것 같네요.

width: 116px;
height: 20px;
display: flex;
justify-content: space-between;
}

@media (min-width: 1920px) {
.part1 {
width: 100%;
}
}

/* 화면의 너비가 1920px 보다 작아질 때, “판다마켓” 로고의 왼쪽 여백 200px“로그인" 버튼의 오른쪽 여백 200px이 유지되고, 화면의 너비가 작아질수록 두 요소간 거리가 가까워지도록 해주세요. */
Loading