-
Notifications
You must be signed in to change notification settings - Fork 42
[이상달] sprint9 #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asksa1256
wants to merge
42
commits into
codeit-bootcamp-frontend:Next-이상달
Choose a base branch
from
asksa1256:Next-이상달-sprint9-1
base: Next-이상달
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
The head ref may contain hidden characters: "Next-\uC774\uC0C1\uB2EC-sprint9-1"
Open
[이상달] sprint9 #229
asksa1256
wants to merge
42
commits into
codeit-bootcamp-frontend:Next-이상달
from
asksa1256:Next-이상달-sprint9-1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Fix] delete merged branch github action
addiescode-sj
approved these changes
Jul 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!
Next.js 첫 미션 스타트를 상달님이 끊어주셨군요 👍
구조적으로 고민해볼만한것 (에러 바운더리 사용 & api 관련 파일 관리) 리팩토링 제안 추천드리고,
Streaming SSR 기반으로 컴포넌트를 분리하는것에 대한 기법과 이점들 위주로 피드백 드려봤습니다!
주요 리뷰 포인트
- 에러 바운더리 사용 관련 제안
- Streaming SSR 장점 활용법
- api 관리 방식 리팩토링 제안
- TailwindCSS 공통된 유틸리티 클래스 지시어를 사용해 관리하기
…Sprint-Mission into Next-이상달-sprint9-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
목록 조회
할 일 추가
할 일 완료
배포 링크
https://doit-next-sd.netlify.app/
주요 변경사항
스크린샷
데이터 없을 때
input 입력 시 '추가하기' 버튼 활성화
todo 추가
done 처리
항목 여러개 추가, done 처리
done 항목 todo로 복원
멘토에게