Skip to content

[강화진] Sprint1 #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged

[강화진] Sprint1 #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a21101d
sprint_mission1 제출
ghkwls9910 Jun 13, 2025
b5e4517
png이미지 추가
ghkwls9910 Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added bottom.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ic_facebook.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ic_instagram.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ic_twitter.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ic_youtube.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added logo.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
249 changes: 249 additions & 0 deletions mission1.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,249 @@
* {
box-sizing: border-box;
margin-left: 0;
margin-top: 0;
margin-bottom: 0;
}

.navbar {
width: 1920px;
height: 70px;
border-bottom-width: 1px;
padding-top: 9px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 padding: 9px 400px 로 축약해서 쓸 수 있습니다.

padding-right: 400px;
padding-bottom: 9px;
padding-left: 400px;
gap: 10px;
}

.nav {
display: flex;
width: 1120px;
height: 51px;
justify-content: space-between;
}

#logo {
width: 153px;
height: 51px;
}

#loginBtn {
background-color: #3692FF;
color: #FFFFFF;
border: none;
width: 128px;
height: 48px;
padding-top: 12px;
padding-right: 23px;
padding-bottom: 12px;
padding-left: 23px;
gap: 10px;
border-radius: 8px;
cursor: pointer;
}

.top {
position: relative;
}

#rectangle {
width: 1920px;
height: 540px;
}

.rectangleBox {
position: absolute;
display: flex;
width: 1110px;
height: 340px;
top: 200px;
left: 405px;
gap: 7px;
}

#introduce {
color: #374151;
width: 295px;
height: 112px;
font-family: Pretendard;
font-weight: 700;
font-size: 37px;
line-height: 140%;
letter-spacing: 0%;
vertical-align: middle;
}

#searchBtn {
background: #3692FF;
color: #FFFFFF;
border: none;
width: 357px;
height: 56px;
padding-top: 16px;
padding-right: 124px;
padding-bottom: 16px;
padding-left: 124px;
gap: 10px;
border-radius: 40px;
cursor: pointer;
}

#rectangleLogo {
width: 746px;
height: 340px;
}

.section {
width: 1920px;
height: 720px;
padding-top: 138px;
padding-right: 466px;
padding-bottom: 138px;
padding-left: 466px;
gap: 10px;
}

.sectionNum {
display: flex;
background-color: #FCFCFC;
width: 988px;
height: 444px;
gap: 64px;
border-radius: 12px;
}

#sectionImg {
width: 579px;
height: 444px;
}

.sectionExplain {
width: 298px;
height: 238px;
padding-top: 50px;
padding-right: 24px;
gap: 12px;

}

#category {
color: #3692FF;
width: 70px;
height: 26px;
font-family: Abhaya Libre ExtraBold;
font-weight: 800;
font-size: 15px;
line-height: 26px;
letter-spacing: 0%;
vertical-align: middle;
}

#smallExplain {
color: #374151;
width: 274px;
height: 64px;
font-family: Pretendard;
font-weight: 500;
font-size: 18px;
line-height: 32px;
letter-spacing: 0%;
vertical-align: middle;
}

.sectionExplain2 {
width: 317px;
height: 238px;
padding-top: 50px;
padding-left: 24px;
gap: 12px;
text-align: right;
}

.bottom {
position: relative;
}

#bottomColor {
width: 1920px;
height: 540px;
top: 2908px;
}

.bottomBox {
position: absolute;
display: flex;
width: 1110px;
height: 397px;
top: 143px;
left: 405px;
gap: 69px;
}

.bottomBox #introduce {
width: 295px;
height: 172px;
padding-top: 90px;
padding-bottom: 60px;
gap: 10px;
font-size: 37px;
}

#bottomImg {
width: 746px;
height: 397px;
}

footer {
background-color: #111827;
width: 1920px;
height: 160px;
top: 3448px;
padding-top: 32px;
padding-right: 400px;
padding-bottom: 32px;
padding-left: 400px;
gap: 10px;
}

footer nav {
color: #9CA3AF;
width: 1120px;
height: 20px;
justify-content: space-between;
}

footer nav span {
display: flex;
float: left;
width: 112px;
height: 19px;
font-family: Pretendard;
font-weight: 400;
font-size: 16px;
line-height: 100%;
letter-spacing: 0%;
text-align: center;
margin-top: 20px;
}

.footerLink {
display: flex;
text-decoration: none;
width: 159px;
height: 19px;
gap: 30px;
padding-left: 350px;
}

.footerLink a {
color: #9CA3AF;
}

.icon {
display: flex;
float: right;
width: 116px;
height: 20px;
gap: 12px;
}
92 changes: 92 additions & 0 deletions mission1.html
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 현재 html, css, 이미지 파일이 모두 루트에 위치해있어 관리가 어려워질 것 같습니다.
    아래 예시 구조와 같이 목적별로 폴더를 분리해서 관리하는걸 추천드립니다.
├── index.html
├── styles/
│   └── home.css
├── assets/
│   ├── images/
│   └── icons/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. mission1.html, mission1.css 와 같은 파일명은 이름만 보고 무슨 페이지인지 유추가 어렵습니다. index.html, landing.html, home.html 등 의미 있는 역할명으로 변경해주세요.

mission1.css도 마찬가지입니다. 프로젝트 전체를 구성하는 스타일이라면 style.css, 특정 페이지라면 home.css와 같이 명확히 지어주시는게 좋습니다.

Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
<!DOCTYPE html>
<html lang="en">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한국어 사이트인 만큼 lang="ko" 가 더 적합할 것 같습니다.

<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>판다마켓</title>
<link rel="stylesheet" href="/mission1.css">
</head>
<body>
<!-- navbar -->
<div class="navbar">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

navbar 와 같은 header 영역을 구현할 때에는 <header> 태그를 사용하면 좋습니다.

<nav class="nav">
<a href="/"><img id="logo" src="/logo.png"></a>
<a href="/login"><button id="loginBtn">로그인</button></a>
</nav>
</div>
<!-- 일상의 모든 물건을 거래해 보세요 -->
<div class="top">
<img id="rectangle" src="rectangle.png" alt="하늘색 이미지">
<!-- 하늘색 박스 안의 내용 -->
<div class="rectangleBox">
<div>
<p id="introduce">일상의 모든 물건을<br>거래해 보세요</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여러 곳에서 id="introduce"가 중복으로 사용되고 있습니다. Id 는 페이지 내에서 고유해야 하므로, 중복되는 Id는 class 로 대체해주시고나 고유 id 로 수정해주세요!

<a href="/items"><button id="searchBtn">구경하러 가기</button></a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<a><button></button></a> 구조는 a와 button 태그가 불필요한 중첩되는 것 같아요. a 태그만 사용하는게 더 좋아보입니다.
(예)
<a href="/items" class="btn">구경하러 가기</a>

</div>
<img id="rectangleLogo" src="rectangleLogo.png">
</div>
</div>
<div>
<!-- section1 -->
<div class="section">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기는 <section> 태그를 활용해보시면 좋겠네요!

<div class="sectionNum">
<img id="section1Img" src="/section1.png">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#sectionImg와 #section1Img 이 혼용되어 사용되고 있습니다. id는 다르게 정의되어 있는데 쓰임은 명확히 구분되지 않는 것 같아요. 하나로 통일하거나 class로 바꾸는게 좋아보입니다.

<!-- section1 소개 글 -->
<div class="sectionExplain">
<p id="category">Hot item</p>
<p id="introduce">인기 상품을<br>확인해 보세요</p>
<p id="smallExplain">가장 HOT한 중고거래 물품을<br>판다 마켓에서 확인해 보세요</p>
</div>
</div>
</div>
<!-- section2 -->
<div class="section">
<div class="sectionNum">
<!-- section2 소개 글 -->
<div class="sectionExplain2">
<p id="category">Search</p>
<p id="introduce">구매를 원하는<br>상품을 검색하세요</p>
<p id="smallExplain">구매하고 싶은 물품은 검색해서<br>쉽게 찾아보세요</p>
</div>
<img id="sectionImg" src="/section2.png">
</div>
</div>

<!-- section3 -->
<div class="section">
<div class="sectionNum">
<img id="sectionImg" src="/section3.png">
<!-- section3 소개 글 -->
<div class="sectionExplain">
<p id="category">Register</p>
<p id="introduce">판매를 원하는<br>상품을 등록하세요</p>
<p id="smallExplain">어떤 물건이든 판매하고 싶은 상품을<br>쉽게 등록하세요</p>
</div>
</div>
</div>
<!-- 믿을 수 잇는 판다마켓 중고 거래 -->
<div class="bottom">
<img id="bottomColor" src="rectangle.png" alt="하늘색 이미지">
<div class="bottomBox">
<p id="introduce">믿을 수 있는<br>판다마켓 중고 거래</p>
<img id="bottomImg" src="bottom.png">
</div>
</div>
<!-- footer -->
<footer>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

시맨틱 태그인 footer 를 사용해주신 점 좋습니다! 👍

<nav class="footer">
<span>@codeit - 2024</span>
<div class="footerLink">
<a href="/privacy"><span id="footerPrivacy">Privacy Policy</span></a>
<a href="/faq"><span id="footerFaq" >FAQ</span></a>
</div>
<div class="icon">
<a href="https://www.facebook.com" target="_blank"><img src="ic_facebook.png"></a>
<a href="https://www.twitter.com" target="_blank"><img src="ic_twitter.png"></a>
<a href="https://www.youtube.com" target="_blank"><img src="ic_youtube.png"></a>
<a href="https://www.instagram.com" target="_blank"><img src="ic_instagram.png"></a>
</div>
</nav>
</footer>
</body>
</html>
Binary file added rectangle.png
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 영역은 굳이 이미지를 삽입하지 않아도 css 속성만으로도 구현 가능할 것 같습니다.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added rectangleLogo.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added section1.png
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미지 파일명도 직관적으로 역할을 알 수 있도록 지어주시는게 좋습니다. section1, section2 처럼 랜덤한 숫자가 붙으면 역할을 파악하기 어려우니 보다 직관적인 이름으로 변경해주시면 좋을 것 같습니다.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added section2.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added section3.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading